bugGNU Octave - Bugs: bug #53978, Octave 4.4 fails to build against...

 
 

bug #53978: Octave 4.4 fails to build against Qt 5.11

Submitter:  Mike Miller <mtmiller>
Submitted:  Fri 25 May 2018 02:29:35 AM UTC
   
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  mtmiller
Originator Name:  Open/Closed:  * Closed
Release:  * 4.4.0 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 25 May 2018 02:32:31 AM UTC, comment #1: 

Fixed on the stable branch with the change

https://hg.savannah.gnu.org/hgweb/octave/rev/cdaa884568b1

Mike Miller <mtmiller>
Group Member
Fri 25 May 2018 02:29:35 AM UTC, original submission:  

Octave fails to compile against Qt 5.11 with a few instances of the following error


../libgui/src/settings-dialog.cc: In constructor ‘settings_dialog::settings_dialog(QWidget*, const QString&)’:
../libgui/src/settings-dialog.cc:302:57: error: invalid use of incomplete type ‘class QButtonGroup’
   QButtonGroup *icon_size_group = new QButtonGroup (this);
                                                         ^
In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qtoolbutton.h:45:0,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QToolButton:1,
                 from ../libgui/src/octave-dock-widget.h:30,
                 from ../libgui/src/variable-editor.h:33,
                 from ../libgui/src/settings-dialog.cc:33:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractbutton.h:53:7: note: forward declaration of ‘class QButtonGroup’
 class QButtonGroup;
       ^~~~~~~~~~~~


all in settings-dialog.cc.

This looks pretty simple and reasonable to fix on stable with an extra include, will test and push the fix as soon as I have a bug number.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-06-16 mtmiller Dependencies- bugs #54124 is dependent
    2018-05-28 mtmiller Dependencies- bugs #53996 is dependent
    2018-05-25 mtmiller StatusConfirmed Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code