bugGNU roff - Bugs: bug #53715, [PATCH] pic2graph.1: Use macro...

 
 

bug #53715: [PATCH] pic2graph.1: Use macro 'TP' without an extra (long) indent

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Sun 22 Apr 2018 01:30:15 AM UTC
   
 
Category:  Utilities Severity:  2 - Minor
Item Group:  Documentation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 10 Jun 2022 10:02:22 PM UTC, comment #2: 


commit 5f6b02c22a9d9c3e84fb369b7f4f1310552cc638
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Apr 22 18:15:42 2018 -0400

    pic2graph(1): Stop trying to outsmart .TP macro.

    Remove gratuitous calculated indent setting.  Most man pages that do
    this trick do it as a way to simulate 2-column output, or a 2-column
    table, but in this case the table would have only one row so there's
    no beautification to be done.

    This trick causes 'can't break line' warnings if, for instance, the
    ./configure --prefix is longer than the man page author expects.  (This
    is often the case.)

    Thanks to Bjarni Ingli Gislason for catching this.

    Fixes bug https://savannah.gnu.org/bugs/index.php?53715.

    Signed-off-by: G. Branden Robinson <g.branden.robinson@gmail.com>


G. Branden Robinson <gbranden>
Group administrator
Sun 22 Apr 2018 06:54:33 AM UTC, comment #1: 

pic2graph is not alone. All of these man pages try to outsmart the TP macro:

eqn.1
indxbib.1
lkbib.1
lookbib.1
pic2graph.1
troff.1

I'm going to see if simplification doesn't also result in beautification.

G. Branden Robinson <gbranden>
Group administrator
Sun 22 Apr 2018 01:30:15 AM UTC, original submission:  


From 3882790050fe8de32f6c6e8ba26dbe2518d98fc0 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Sat, 21 Apr 2018 22:47:07 +0000
Subject: [PATCH] pic2graph.1: Use macro 'TP' without an extra (long) indent

  A long indent wastes space, can cause a "can't break line" warning,
and causes a bad (worse) formatting.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 contrib/pic2graph/pic2graph.1.man | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/pic2graph/pic2graph.1.man b/contrib/pic2graph/pic2graph.1.man
index 784aff5f..42f5ecc6 100644
--- a/contrib/pic2graph/pic2graph.1.man
+++ b/contrib/pic2graph/pic2graph.1.man
@@ -148,7 +148,7 @@ Command-line switches and arguments not listed above are passed to
 .SH FILES
 .\" ====================================================================
 .
-.TP \w'\fB@MACRODIR@/eqnrc'u+2n
+.TP
 .B @MACRODIR@/eqnrc
 The
 .BR @g@eqn (@MAN1EXT@)
--
2.17.0


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Updated the item)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-15 gbranden CategoryNone Utilities
    2022-06-10 gbranden Planned ReleaseNone 1.22.4
    2018-04-23 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2018-04-22 gbranden StatusNone In Progress
        Assigned toNone gbranden
    2018-04-22 gbranden Severity3 - Normal 2 - Minor

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code