bugCompact Disc Input and Control Library - Bugs: bug #52491, Bad value for LIBCDIO_VERSION_NUM

 
 

bug #52491: Bad value for LIBCDIO_VERSION_NUM

Submitter:  Christian Marillat <marillat>
Submitted:  Thu 23 Nov 2017 11:03:08 PM UTC
   
 
Category:  API Severity:  5 - Average
Item Group:  libcdio Status:  Fixed
Privacy:  Public Assigned to:  rocky
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 23 Nov 2017 11:33:40 PM UTC, comment #1: 

Yes, I think you are correct that LIBCDIO_VERSION_NUM is not set in a helpful way and that "cut" is now faulty.

In commit 2d22ae1 on the "dev" branch I have hand coded this for now to 10001 (the branch release there is 1.0.1 to follow a convention that x.y.zjunk => x*10000 + y*100 + z

This puts a limit of no more than 99 minor or release numbers, but that has been the case for the first 17 years or so.

Thanks for reporting

Rocky Bernstein <rocky>
Group administrator
Thu 23 Nov 2017 11:03:08 PM UTC, original submission:  

Hi,

Since the 1.0.0 release LIBCDIO_VERSION_NUM is defined to 1

This definition is set from RELEASE_NUM=1.0.0 in configure.ac like
LIBCDIO_VERSION_NUM=`echo RELEASE_NUM | cut -d . -f 1 | tr -d a-z`

This meant that with previous release we have a number like 94 and now with 1 all software's who test LIBCDIO_VERSION_NUM fail to build.

The best I think is to set LIBCDIO_VERSION_NUM to 100

Christian

Christian Marillat <marillat>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rocky (Posted a comment)
  • -email is unavailable- added by marillat (Submitted the item)
  • -email is unavailable- added by marillat
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-04-13 rocky Open/ClosedOpen Closed
    2019-04-13 rocky StatusIn Progress Fixed
    2017-11-23 rocky Item GroupNone libcdio
        StatusNone In Progress
        Assigned toNone rocky
    2017-11-23 marillat Carbon-Copy- Added marillat

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code