bugGNU Octave - Bugs: bug #51511, [octave forge] odepkg repo fails...

 
 

bug #51511: [octave forge] odepkg repo fails build in dev octave

Submitter:  John Donoghue <lostbard>
Submitted:  Wed 19 Jul 2017 07:43:58 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  JohnD Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sat 26 Jan 2019 02:22:17 AM UTC, comment #11: 

The current odepkg repository builds with both Octave 4.4 and 5.0.90, closing as fixed.

Mike Miller <mtmiller>
Group Member
Mon 31 Jul 2017 02:02:43 PM UTC, comment #10: 

Hi, I applied the patch here:

  https://bitbucket.org/odepkg/odepkg/commits/all

Thanks!

BTW applying the patch was not automatic, if you keep
working on odepkg it would be easier to provide changeset
with respect to the actual development repository rather
than the OF mirror.


Carlo de Falco <cdf>
Group Member
Sun 23 Jul 2017 06:43:47 PM UTC, comment #9: 

Which other packages? I find only the ocs package, and there the dependency seems to be merely nominal: No function of the current odepkg seems to be called. And BTW the ODE solvers meant to be used by ocs are not even available under the used names in current Octave.

Olaf Till <i7tiol>
Group Member
Sun 23 Jul 2017 01:11:39 PM UTC, comment #8: 

I hope so too -  some other packages depend on odepkg, so they will no longer work with dev octave.

If there is any windows testing I can help with let me know.

John Donoghue <lostbard>
Group Member
Sat 22 Jul 2017 07:20:36 PM UTC, comment #7: 

I hope your efforts will result in a new release, but I've removed the package from the list at our website until this happens. The repository will still be available for now.

Since this is an external package, we wholly depend on the maintainer for inclusion of patches and for making a release.

Jacopo, you have commit access to the Octave Forge repository, too, not only Carlo.

Olaf Till <i7tiol>
Group Member
Fri 21 Jul 2017 01:19:26 PM UTC, comment #6: 

For the toplevel makefile:


/usr/share/texlive/texmf-dist/tex/generic/epsf/epsf.tex
This is `epsf.tex' v2.7.4 <14 February 2011>
) localization, formatting, and turning on texinfo input format.) [1] [2]
[-1] Chapter 1 Cross reference values unknown; you must run TeX again. [1]
[2] [3] Chapter 2 [4] [5] [6]
/home/johnd/octave_forge_packages/odepkg/doc/odepkg.texi:721: This command can
appear only in environment @{multitable}, not in environment @multitable.
@badenverr ...temp , not @inenvironment @thisenv }

@checkenv ...@ifx @thisenv @temp @else @badenverr
                                                  @fi
@\end ...pandafter @checkenv @csname #1@endcsname
                                                  @csname E#1@endcsname @end...
l.721 @end{multitable}


John Donoghue <lostbard>
Group Member
Fri 21 Jul 2017 12:06:06 PM UTC, comment #5: 

I took a quick look at the bitbucket repo and it will compile after I apply  the patch previously attached.

The top level makefile (in this repo as well as the octave forge repo) both stop in generation of docs from texinfo, so I might be missing something it needs to do that.

Attempting to install on my fedora box, it has same issue of never returning from get_help_text as per comment #3 (installs ok in windows although does take a while (minutes) to process the doc cache though)

Running the tests in windows produces same pass/fail numbers as comment #2.



John Donoghue <lostbard>
Group Member
Fri 21 Jul 2017 07:19:12 AM UTC, comment #4: 

I know I am lagging behind with new release. I am sorry.

Some work has indeed been made by CdF and myself on a separated bitbucket repository (https://bitbucket.org/odepkg/odepkg) and it should fix the main issues. I do not have access to a development version of Octave, but it compiles and install successfully on my 4.2.

I asked CdF if he could push this changes to sourceforge as soon as possible.

Jacopo Corno <jcorno>
Thu 20 Jul 2017 05:51:20 PM UTC, comment #3: 

Using the patches, it compiles ok in fedora, however gets stuck in the pkg install forever (or at least was still going a couple of ours later)

It appears to be the doc_cache_create.m calling get_help_text for dldsolver.


John Donoghue <lostbard>
Group Member
Thu 20 Jul 2017 01:35:22 PM UTC, comment #2: 

Yep - released package does not build in 4.2+, I saw JWE had pushed a patch to the repo in Jan 2017 that fixed (for me at least) that for 4.2, and was also added to mxe-octave.

Using the repo, with my patch as well, built for windows i686-w64-mingw32 in 4.3.0+ and in 4.2.1, test results:

  PASS                              165
  FAIL                              295


Log of test failures attached

(file #41265)

John Donoghue <lostbard>
Group Member
Thu 20 Jul 2017 11:11:12 AM UTC, comment #1: 

Have you checked package building?

When I tested in March 2017, the latest release segfaulted with Octave-4.0 and didn't build with Octave-4.2. And there were no commits since then, far less a release, although promised; only statements that the external clone works.

If it were not for my hesitation, I'd have probably already come to a decision to remove this package from our list. I probably should make some final tests and do it now, except someone steps in and makes a release.

Olaf Till <i7tiol>
Group Member
Wed 19 Jul 2017 07:43:58 PM UTC, original submission:  

Recent changes to dev octave have removed some global path variables, which are checked for in the packages configure, even though they are not used.

Patch attached that removes the checks

John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41265:  odepkg-0.9.1-fntests.log added by lostbard (89KiB - application/octet-stream)
file #41250:  ode-fixdev.patch added by lostbard (7KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cdf (Posted a comment)
  • -email is unavailable- added by i7tiol (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-01-26 mtmiller StatusNone Fixed
        Open/ClosedOpen Closed
    2017-07-20 lostbard Attached File- Added odepkg-0.9.1-fntests.log, #41265
    2017-07-19 lostbard Carbon-Copy- Added jcorno
    2017-07-19 lostbard Attached File- Added ode-fixdev.patch, #41250

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code