bugmake - Bugs: bug #50372, gmk_floc missing offset member

 
 

bug #50372: gmk_floc missing offset member

Submitter:  None
Submitted:  Tue 21 Feb 2017 07:18:21 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Component Version:  4.3 Operating System:  Any
Fixed Release:  None Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 01 Jan 2023 07:20:07 PM UTC, comment #1: 

The offset field is not really needed by the load setup function.  It only has a value inside a recipe: lineno is the line number of the start of the rule, and offset is the number of lines into the recipe.  Since load operations don't appear within recipes this offset value will be zero anyway.

I suppose that it's possible that a load directive could be invoked from within an eval function in a recipe.

Paul D. Smith <psmith>
Group administrator
Tue 21 Feb 2017 07:18:21 PM UTC, original submission:  

The definition of the gmk_floc struct is not consistent with the floc struct used in calling the dynamic objects' initialization function.

The attached patch corrects the gmk_floc definition. It also includes suggested changes to the documentation.

This fix does not resolve violation of C strict aliasing rules. For this we would need to use the same floc struct.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #39806:  gnumake-gmk-floc-fix.patch added by None (3KiB - text/x-diff - Patch to current git repository version.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-02-21 None Attached File- Added gnumake-gmk-floc-fix.patch, #39806

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code