bugGNU Astronomy Utilities - Bugs: bug #47866, Small generic fixes (e.g., typos,...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #47866: Small generic fixes (e.g., typos, one-liners)

Submitter:  Mosè Giordano <giordano>
Submitted:  Fri 06 May 2016 01:23:07 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  Source code Status:  In Progress
Privacy:  Public Assigned to:  None
Open/Closed:  Open

Jump to the original submission

Mon 24 Apr 2023 07:45:03 PM UTC, comment #21: 

Thanks a lot Bharat! This typo fixing commit has been merged into the master branch in Commit df53400a9.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sat 11 Mar 2023 05:08:46 PM UTC, comment #20: 

Hello, I noticed some typos in the conditional operator section of the documentation. I have corrected it.
Branch: https://github.com/Bharat-bhandari/gnuastro
Commit: https://github.com/Bharat-bhandari/gnuastro/compare/master...docs/fix-typos-in-Conditional-operators

Please have a look.
Thank you


Bharat <bharat>
Sun 03 Dec 2017 03:12:32 AM UTC, comment #19: 

Very nice corrections, thanks Vladimir. The fix has been merged into the master and pushed to the main repo.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sun 03 Dec 2017 12:54:05 AM UTC, comment #18: 

A pull request to fix two one-liners:

1. Double check the same option in if condition (in fits)
2. Non-critical memory leak (in buildprog)

Branch:
https://github.com/VladimirMarkelov/gnuastro-vvm/tree/small-fixes

Commit:
https://github.com/VladimirMarkelov/gnuastro-vvm/commit/6101f1df80dd230c0e16f25b09b9b523f44b554c

Vladimir Markelov <vvm>
Sat 06 May 2017 04:54:24 PM UTC, comment #17: 


> I just noticed one thing after fetching the commit: the executable
> flag on all the files had been removed. So I made them executable
> again.


That was my fault, sorry! [The command `sed ... file1 > file2' does not
preserve file permissions. So `patch' would have been safer.]

Boud Roukema <boud>
Group Member
Sat 06 May 2017 04:14:02 PM UTC, comment #16: 

Thanks a lot Boud, it has been merged with the master branch. I just noticed one thing after fetching the commit: the executable flag on all the files had been removed. So I made them executable again.

There is indeed no template for the files. So far, every time a test was added, the file of another similar test was copied and corrected. It would be interesting if we can design such a template, but so far, I haven't had the time. The customizations for some tests might be different, so desgining such a template wasn't trival.

Thanks again for the typo correction.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sat 06 May 2017 12:31:56 AM UTC, comment #15: 

I propose this set of typo corrections (s/variabels/variables) in this commit:

https://bitbucket.org/broukema/gnuastro/commits/8499ac9504927edae0ae0290439cfcf059c136f4?at=typos_eg_simpleio

I couldn't find a template source for these 48 files, so I
edited them in the command line.

Boud Roukema <boud>
Group Member
Sat 13 Aug 2016 09:40:38 AM UTC, comment #14: 

Great, thanks, it is now merged with master.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sat 13 Aug 2016 03:04:32 AM UTC, comment #13: 

One more little change: replace file name in two error message in src/noisechisel/binary.c:

Branch

Patch

Vladimir Markelov <vvm>
Wed 27 Jul 2016 12:45:00 PM UTC, comment #12: 

Thanks Vladimir, the typo corrections have been merged with master and pushed to the main repo.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Wed 27 Jul 2016 02:36:21 AM UTC, comment #11: 
Vladimir Markelov <vvm>
Mon 09 May 2016 09:16:23 AM UTC, comment #10: 

Yes, it was my mistake while I was working on a parallel branch (to automatically create version numbers) and created the new doc/genauthors. I copied the old changes into the file, then when your change came, I put your changes in the new file by hand and missed some of them. This was not the best thing to do!

I did separate all the the other parallel work during that larger work into separate branches so they don't get mixed, but this particular change slipped through my fingers! Sorry for that and thank you for correcting me.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sun 08 May 2016 03:58:51 PM UTC, comment #9: 

In my "genauthors" script there are fixes to genauthors scripts.  Some of these change were already applied in previous commits but disappeared when the commands were moved from the Makefile to the external script

Mosè Giordano <giordano>
Group Member
Sun 08 May 2016 11:12:50 AM UTC, comment #8: 

Thanks, it is merged in master.

After updating to GCC 6.1, I got some useful warnings on clearly separating two blocks in the code, which I also corrected and have pushed to master.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sun 08 May 2016 10:39:14 AM UTC, comment #7: 

Minor documentation fix is available in my "doc" branch.

Mosè Giordano <giordano>
Group Member
Sun 08 May 2016 02:19:30 AM UTC, comment #6: 

The `authors-rule' branch is now merged into master.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sun 08 May 2016 12:40:14 AM UTC, comment #5: 

New branch "authors-rule" contains fixes to "authors.texi" rule in Makefile.am

Mosè Giordano <giordano>
Group Member
Sat 07 May 2016 11:28:34 AM UTC, comment #4: 

Thank you very much, they are both merged into master.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sat 07 May 2016 11:04:21 AM UTC, comment #3: 

New branches "doc" and "quotes" are present in my repository, please have a look at them.

Mosè Giordano <giordano>
Group Member
Sat 07 May 2016 05:09:17 AM UTC, comment #2: 

Thank you for making this special bug. We will always keep it "Open", but change the status on every new comment on it, so now that your changes have been merged to master, it is "fixed". But the next time someone finds such bugs, they should change it to "Confirmed", or any other relevant state.

For the .gitignore commit, I added a small comment on top of the file reminding our selves that the files have to be added in order of line-length to be easy to the eye, since it is a long list. So I also put the two added lines in their correct place.

For the change in bootstrap.conf. I was impressed by your idea in using `$GNULIB_SRCDIR/../autoconf-archive/' instead of my tiny SED script! It was a great and elegant correction, thank you. Since we don't use SED anymore, I also updated this in the documentation (where I had previously warned that the top directory must not have the string `gnulib' in it, because SED would mess it up). Your idea to use `curl' when `wget' isn't present was also great. Thanks.

They are both now pushed to master.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Fri 06 May 2016 01:25:36 PM UTC, comment #1: 

I pushed to my repository two branches, gitignore and downloader.

The former adds a couple of files to .gitignore, the latter adds the ability to better detect the program with which to download files from the web during bootstrap.

Mosè Giordano <giordano>
Group Member
Fri 06 May 2016 01:23:07 PM UTC, original submission:  

This ticket can be used to submit patches to fix small issues that don't deserve new bug reports.

Mosè Giordano <giordano>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bharat (Posted a comment)
  • -email is unavailable- added by boud (Posted a comment)
  • -email is unavailable- added by vvm (Posted a comment)
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by giordano (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-12-26 boud DependenciesRemoved dependency from bugs #49932 -
    2016-12-26 boud DependenciesRemoved dependency from bugs #49932 -
    2016-12-26 boud Dependencies- bugs #49932 is dependent
    2016-12-24 makhlaghi SummarySmall generic fixes Small generic fixes (e.g., typos, one-liners)
    2016-07-27 vvm StatusFixed In Progress
    2016-05-07 makhlaghi StatusNone Fixed

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code