GNU Scientific Library - Bugs: bug #36197, reserved identifier violation
You are not allowed to post comments on this tracker with your current authentication level.
bug #36197: reserved identifier violation
Submitter: | Markus Elfring <elfring> | ||
Submitted: | Sun 15 Apr 2012 04:11:38 PM UTC | ||
Category: | Build | Severity: | 3 - Normal |
Operating System: | Status: | None | |
Assigned to: | None | Open/Closed: | Open |
Release: |
Jump to the original submission
Sat 05 Mar 2016 07:23:24 PM UTC, comment #6: |
M Welinder <terra> |
Sun 03 Jun 2012 09:14:39 AM UTC, comment #5: Appending a UUID would definitely reduce the probability of name clashes. However, we don't seem to have a name clash problem given that there are no outstanding bugs from name clashes and GSL is more than 16 years old. |
Rhys Ulerich <rhysu> |
Sun 03 Jun 2012 08:44:48 AM UTC, comment #4: How do you think about to append a kind of UUID to your include guards so that the probability for name clashes can be reduced a bit more? |
Markus Elfring <elfring> |
Sun 03 Jun 2012 01:19:50 AM UTC, comment #3: Thanks for the clarification.
|
Rhys Ulerich <rhysu> |
Sat 02 Jun 2012 09:10:29 PM UTC, comment #2: I suggest to be more careful with the use of double underscores for identifiers in your source files.
|
Markus Elfring <elfring> |
Sat 02 Jun 2012 05:35:19 PM UTC, comment #1: I agree that "__GSL_MATH_H_" is problematic according to the link you sent. That fix is just a judicious 'perl -pi -e' invocation across the code base and should be doable.
|
Rhys Ulerich <rhysu> |
Sun 15 Apr 2012 04:11:38 PM UTC, original submission:
I would like to point out that an identifier like "_GSL_MATH_H_" does not fit to the expected naming convention of the C++ language standard.
|
Markus Elfring <elfring> |
Depends on the following items: None found
Items that depend on this one: None found
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2013-03-30 | elfring | Attached File | - | Added 36197a.diff, #27727 | |
Attached File | - | Added 36197b.diff, #27728 |
Powered by Savane 3.13-f8d8.
Corresponding source code
For completeness, here is a bunch of further reserved
identifiers being used. (errno.h reserves these as per
C99 Section 7.5)
#define ETA_POS_TABLE_NMAX 100
#define ETA_NEG_TABLE_NMAX 99
#define ETA_NEG_TABLE_SIZE 50
#define EVAL_RESULT(fn) \
#define EVAL_DOUBLE(fn) \
#define EXPAND(x) STRING(x)
#define NAME(x) EXPAND(TYPE(x))
#define ELEMENT(a,stride,i) ((a)[(stride)*(i)])
#define ERR(i) sqrt(gsl_matrix_get(covar,i,i))
#define EXTRA 10
#define EVAL(f,x) ((*((f)->function))(x,(f)->params))
#define EXIT_SUCCESS 0
#define EXIT_FAILURE 1