bugmake - Bugs: bug #65739, Add warnings circular-dep and...

 
 

bug #65739: Add warnings circular-dep and circular-extra-dep.

Submitter:  Dmitry Goncharov <dgoncharov>
Submitted:  Tue 14 May 2024 01:40:55 AM UTC
   
 
Severity:  3 - Normal Priority:  5 - Normal
Item Group:  Enhancement Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Component Version:  SCM
Operating System:  Any Fixed Release:  SCM
Triage Status:  None
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Sun 19 May 2024 11:26:48 PM UTC, comment #3: 

I applied the first patch (with a few tweaks).  Thanks!

Let's discuss the second patch in bug #60736 instead

Paul D. Smith <psmith>
Group administrator
Tue 14 May 2024 02:03:20 AM UTC, comment #2: 

Here is an example


$ cat makefile
hello: hello
$ make
make: circular hello <- hello dependency dropped
make: Nothing to be done for 'hello'.
$ make --warn=circular-dep:ignore
make: Nothing to be done for 'hello'.
$ make --warn=circular-dep:error
make: *** circular hello <- hello dependency dropped.  Stop.
$ echo $?
2


Dmitry Goncharov <dgoncharov>
Tue 14 May 2024 01:57:48 AM UTC, comment #1: 

Patch sv65739_circular_dep_warn_part1.diff adds warning
circular-dep. This warning controls how makes handles circular dependencies.
The behavior is to silently drop the dependency, print a message or print a message
and exit with an error code.
The default behavior is to print a message.

Patch sv65739_circular_dep_warn_part2.diff adds warning
circular-extra-dep. This warning is similar to circular-dep.
circular-extra-dep controls handling of circular dependencies caused by
.EXTRA_PREREQS.

This changeset is split to two commits to allow for dedicated commit messages
and provides ability to revert one of the commits, if needed.

The original user request can be found here
https://lists.gnu ... -05/msg00013.html.

Dmitry Goncharov <dgoncharov>
Tue 14 May 2024 01:40:55 AM UTC, original submission:  

.

Dmitry Goncharov <dgoncharov>

 

Attached Files

Attached Files

(Note: upload size limit is set to 16MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by dgoncharov (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    History

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-08-05 psmith StatusNone Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone SCM
    2024-05-14 dgoncharov Attached File- Added sv65739_circular_dep_warn_part1.diff, #56044
        Attached File- Added sv65739_circular_dep_warn_part2.diff, #56045

    Back to the top

    Powered by Savane 3.16.
    Corresponding source code