bugThe oSIP library - Bugs: bug #55930, Fail to parse SIP MESSAGE with...

 
 

bug #55930: Fail to parse SIP MESSAGE with image attached

Submitter:  None
Submitted:  Fri 15 Mar 2019 06:53:58 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  aymeric
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 18 Mar 2019 02:00:34 PM UTC, comment #1: 

Tks a lot for your report!

I have updated the official git with 10000 value. It looks still very short for you, but should fit 99,99% of standard SIP usage where large SIP message should not be allowed... ;)

http://git.savannah.gnu.org/cgit/osip.git/commit/?id=afe336029155811834a179e9c3755cac8289e931

I understand I should rewrite this code to make it more compliant. The loop is stupid...

Tks a lot again,
Aymeric

Aymeric MOIZARD <aymeric>
Group administrator
Fri 15 Mar 2019 06:53:58 PM UTC, original submission:  

If the message features a image in the body, parsing the message fails on a syntax error. Turns out the function __osip_find_next_occurence can only bear up to 1000 '\0', which can be rapidly a problem with a JPG embedded in a multipart.

I find it idiotic to be able to send binary in A TEXT PROTOCOL (damn it, base64 your binaries people!), but the RFC allows it, so...

For now, I'll just bump this limit to 100000 to my local version, but I think we need to have a better way to handle this kind of stupidity.

See file attached.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46547:  coin added by None (7KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by aymeric (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-18 aymeric StatusNone Wont Fix
        Assigned toNone aymeric
        Open/ClosedOpen Closed
    2019-03-15 None Attached File- Added coin, #46547

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code