bugLibreJS - Bugs: bug #53038, Incorrect interface for missing...

 
 

bug #53038: Incorrect interface for missing (404) external scripts

Submitter:  Andrew Engelbrecht <sudoman>
Submitted:  Thu 01 Feb 2018 04:00:41 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  In Progress
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 27 Feb 2018 05:42:19 AM UTC, comment #9: 

this issue seems to be clear now - i will mark this as 'confirmed'

bill-auger <bill_auger>
Group Member
Mon 26 Feb 2018 11:00:12 PM UTC, comment #8: 

Thanks for looking into this. It turns out that our site's template is behaving strangely, so getting you a working example would be non-trivial.

As for the issue, I don't think it make sense to report a freedom issue on a non-existent file. If a file is missing, users should not get an alert that the site uses non-free JavaScript. What if the rest of the JavaScript is okay? Why should site creators be punished for such an edge case? How is this protecting user freedom?

Why not just skip over files that cannot be accessed?

Andrew Engelbrecht <sudoman>
Mon 26 Feb 2018 10:47:28 PM UTC, comment #7: 

I don't think that any examples of this behavior are necessary because I understand the issue.

The confusion here is that LibreJS will put scripts in the "Blocked" category when the parser can't parse them, which in this case is caused by the script being a 404 error.

LibreJS does this because it wouldn't be logical to do anything but  deny scripts that the parser can't make sense of.

Nathan Nichols <nate_nichols>
Group Member
Mon 26 Feb 2018 04:36:05 PM UTC, comment #6: 

Sorry for being unclear. Bill, it seems like you have the right idea. The links I provided were scripts that were referenced from fsf.org.

When the the page loads, Abrowser obviously ignores the files because it cannot load them. However LibreJS reports a freedom issue and says that they cannot be parsed. Because there is no use in complaining about the non-free nature of a non-existent file, it would make sense to simply not report anything about that missing file. This makes sense because site developers will not add a web labels entry for a file that they don't even host, but perhaps they forgot to remove an script tag from their html.

Those links were originally included via script tags on fsf.org. I believe that I commented them out or removed them when I created this bug report, so I'll try to find other examples.

Andrew Engelbrecht <sudoman>
Sun 25 Feb 2018 05:59:38 PM UTC, comment #5: 

i still dont understand this problem exactly but going only by the literal meaning of words i see here - i would have to say that it is not acceptable behavior to throw an error because of a missing script - even so it is a network error and not a parsing error - the browser itself has no problem with missing scripts - they are uneventful i.e. not worth mentioning except for debugging - it just keeps rendering what is can - librejs should do the same - the only information librejs should display should be related to freedom issues

again i am perhaps misunderstanding - id like to see if andrew will clarify this one

bill-auger <bill_auger>
Group Member
Sun 25 Feb 2018 05:38:00 PM UTC, comment #4: 

JavaScript getting blocked because it can't be parsed is meant to be a catch-all for when the parser throws an error.

If 404 scripts show up as "cannot be parsed" in the menu, isn't this acceptable behavior?

Nathan Nichols <nate_nichols>
Group Member
Sat 24 Feb 2018 12:53:25 AM UTC, comment #3: 

trying to confirm this but both of the links given are non-exiting pages - can you find an example page that demonstrates this bug?

also, regarding the problem description: "missing javascript files fail to properly parse" - could you clarify what is the the actual error? - obviously a file must exist in order to be successfully parsed but what demonstrable problem does this cause?

bill-auger <bill_auger>
Group Member
Fri 23 Feb 2018 03:09:14 PM UTC, comment #2: 

The reported issue exists on libreJS v0.7.

Andrew Engelbrecht <sudoman>
Fri 23 Feb 2018 03:37:08 AM UTC, comment #1: 

note that libreJS v0.7 is a nearly total re-write; so this issue very likely refers to only one of them

can you specify which version of libreJS this behavior apllies to?

if this behavior is seen using libreJS v0.6, could you try libreJS v0.7 on a firefox derivative >= v57 to see if the same issue still exists?

bill-auger <bill_auger>
Group Member
Thu 01 Feb 2018 04:00:41 PM UTC, original submission:  

on fsf.org, missing javascript files fail to properly parse, including:

https://static.fsf.org/nosvn/plone2012/++resource++plone.app.discussion.javascripts/comments.js
https://www.fsf.org/tiny_mce_init.js

perhaps they should be ignored?

Andrew Engelbrecht <sudoman>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rubenquidam (Updated the item)
  • -email is unavailable- added by nate_nichols (Posted a comment)
  • -email is unavailable- added by bill_auger (Posted a comment)
  • -email is unavailable- added by sudoman (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-06-01 rubenquidam StatusConfirmed In Progress
        Summaryerror parsing missing javascript Incorrect interface for missing (404) external scripts
    2018-02-27 bill_auger StatusNeed Info Confirmed
    2018-02-23 bill_auger StatusNone Need Info

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code