bugGNU Octave - Bugs: bug #51978, [octave forge] (image) Typo in...

 
 

bug #51978: [octave forge] (image) Typo in unit test for watershed

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Sun 10 Sep 2017 02:18:01 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  carandraug
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 13 Sep 2017 12:10:26 PM UTC, comment #2: 

I have pushed the fix. That test still fails though since we haven't yet figured out what Matlab is doing. For what is worth, Octave's solution is also correct, that test unit is an ill-defined problem.

http://hg.code.sf.net/p/octave/image/rev/617861a926ec

Carnë Draug <carandraug>
Group Member
Wed 13 Sep 2017 04:56:47 AM UTC, comment #1: 

This patch fixes the typo, thanks.
(there is a typo in patch summary: noames->names)
Adding package maintainer to CC.

Avinoam Kalma <avinoam>
Group Member
Sun 10 Sep 2017 02:18:01 PM UTC, original submission:  

The variables im_full and matlab_result_full in one of the unit tests of function watershed are clearly wrongly named. The path attached below fixes the problem.

Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-13 carandraug StatusPatch Reviewed Fixed
        Open/ClosedOpen Closed
    2017-09-13 avinoam StatusNone Patch Reviewed
        Assigned toNone carandraug
        Carbon-Copy- Added -email is unavailable-
    2017-09-10 rlaboiss Attached File- Added typo-unit-test-watershed.patch, #41775

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code