bugGNU Octave - Bugs: bug #50906, .cc files which do not include...

 
 

bug #50906: .cc files which do not include their corresponding header file

Submitter:  Rik <rik5>
Submitted:  Mon 01 May 2017 04:37:24 PM UTC
   
 
Category:  Libraries Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 03 May 2017 12:51:16 AM UTC, comment #2: 

I took care of the most obvious ones here: http://hg.savannah.gnu.org/hgweb/octave/rev/314d980bee93.

Closing report.

Rik <rik5>
Group administrator
Tue 02 May 2017 07:01:55 PM UTC, comment #1: 

For the files like CColVector.cc, the corresponding header files are included because of mx-base.h.

oct-norm.{h,cc} is definitely a weird one...

I assume most of the others eventually include the corresponding .h file by way of including some other header.  But making that explicit shouldn't hurt.

John W. Eaton <jwe>
Group administrator
Mon 01 May 2017 04:37:24 PM UTC, original submission:  

Many .cc files do not include their own header file.  This is odd.  I used a Perl script to generate a list of instances that need attention.


liboctave/array/CColVector.cc
liboctave/array/CDiagMatrix.cc
liboctave/array/chMatrix.cc
liboctave/array/CRowVector.cc
liboctave/array/dColVector.cc
liboctave/array/dDiagMatrix.cc
liboctave/array/dRowVector.cc
liboctave/array/fCColVector.cc
liboctave/array/fCDiagMatrix.cc
liboctave/array/fColVector.cc
liboctave/array/fCRowVector.cc
liboctave/array/fDiagMatrix.cc
liboctave/array/fRowVector.cc
liboctave/array/intNDArray.cc
liboctave/array/MSparse.cc
liboctave/numeric/oct-norm.cc
liboctave/numeric/sparse-dmsolve.cc
liboctave/util/singleton-cleanup.cc
libinterp/corefcn/data.cc
libinterp/corefcn/defaults.cc
libinterp/corefcn/ft-text-renderer.cc
libinterp/corefcn/mex.cc
libinterp/corefcn/oct-hdf5-types.cc
libinterp/corefcn/toplev.cc
libinterp/parse-tree/jit-util.cc
libinterp/parse-tree/oct-parse.cc
libinterp/parse-tree/pt-bp.cc
libinterp/parse-tree/pt-check.cc
libinterp/parse-tree/pt-pr-code.cc
libgui/graphics/__init_qt__.cc



Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #40547:  h.cc.mismatch.list added by rik5 (933B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-05-03 rik5 StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2017-05-01 rik5 Attached File- Added h.cc.mismatch.list, #40547

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code