bugGNU Octave - Bugs: bug #49952, Incorrect license in appdata file

 
 

bug #49952: Incorrect license in appdata file

Submitter:  Orion Poplawski <opoplawski>
Submitted:  Thu 29 Dec 2016 04:36:23 PM UTC
   
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  7 - High Item Group:  Installation Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 4.2.0 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 13 Jan 2017 11:45:01 PM UTC, comment #11: 

I include the permalink and <image> tag from comment #8 and finally checked in the cset on the stable branch (http://hg.savannah.gnu.org/hgweb/octave/rev/1c98489534aa).

Rik <rik5>
Group administrator
Fri 13 Jan 2017 11:14:02 PM UTC, comment #10: 

We have a permalink to the latest screenshot now at https://www.gnu.org/software/octave/img/screenshot.png, I think that is what should go in the appdata file.

Also, the validator doesn't seem to care in comment #8, but according to the spec the screenshot must have an image tag, like this


<screenshots>
  <screenshot type="default">
    <image>https://www.gnu.org/software/octave/img/screenshot.png</image>
  </screenshot>
</screenshots>


Weird that the spec only says the screenshot width must be at least 620 px, no mention of an upper limit. In fact the example listed in the spec is a 1600x900 PNG image.

Apparently, looking at the validator source, the built-in maximum dimensions are indeed 1600x900. We could certainly keep that in mind for future screenshots.

Mike Miller <mtmiller>
Group Member
Fri 13 Jan 2017 10:25:44 PM UTC, comment #9: 

I changed "updatecontact" to "update_contact" per the warning in the validation.  I have a question out about the screenshot on the Octave-Maintainer's mailing list, but I doubt we fix the height, width, and aspect ratio at this time.

Rik <rik5>
Group administrator
Fri 13 Jan 2017 09:36:20 PM UTC, comment #8: 

# appstream-util validate-relax /data/sw/tmp/octave.appdata.xml
/data/sw/tmp/octave.appdata.xml: FAILED:
• tag-invalid           : <project_group> is not valid
Validation of files failed

this is what is required to pass in Fedora.  For Fedora we currently strip out <project_group> from the file until that mess can get resolved.

# appstream-util validate-strict /data/sw/tmp/octave.appdata.xml
/data/sw/tmp/octave.appdata.xml: FAILED:
• tag-missing           : <translation> not specified
• tag-invalid           : <updatecontact> should be <update_contact>
• tag-invalid           : <project_group> is not valid
• attribute-invalid     : <screenshot> width too large https://www.gnu.org/software/octave/img/screenshot-octave-4-2.png
• attribute-invalid     : <screenshot> height too large https://www.gnu.org/software/octave/img/screenshot-octave-4-2.png
• aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9 https://www.gnu.org/software/octave/img/screenshot-octave-4-2.png
• translations-required  : <name> has no translations
• translations-required  : <summary> has no translations
• translations-required  : <description> has no translations
Validation of files failed

Orion Poplawski <opoplawski>
Fri 13 Jan 2017 09:15:32 PM UTC, comment #7: 

I've incorporated the changes suggested in this bug report into a cset which is attached as appdata.cset.  Please review.

In addition, I am attaching the resulting appdata.xml file so Orion can verify that it passes validation.

(file #39470, file #39471)

Rik <rik5>
Group administrator
Fri 13 Jan 2017 05:31:40 PM UTC, comment #6: 

I guess they want the license of the XML file itself to be permissive so that it can be copied and dropped into other projects, such as a repository of metadata files for a system installer.

I agree that FSFAP is probably the most appropriate one to use here.

Mike Miller <mtmiller>
Group Member
Fri 13 Jan 2017 05:25:23 PM UTC, comment #5: 

For what is worth, the image, symbolic, and interval package at Octave Forge use FSF all permissive (FSFAP) for this:

hg.code.sf.net/p/octave/image/file/fe3d2e29deb9/octave-image.metainfo.xml

http://hg.code.sf.net/p/octave/interval/file/db9f2451b867/octave-interval.metainfo.xml

https://sourceforge.net/p/octave/symbolic/ci/master/tree/octave-symbolic.metainfo.xml

Carnë Draug <carandraug>
Group Member
Fri 13 Jan 2017 04:38:20 PM UTC, comment #4: 

What should we use for the metadata_license?

From the documentation link that Carnë sent


<metadata_license/>
    The <metadata_license/> tag is indicating the content license that you are releasing the one metadata file as. This is not typically the same as the project license. By ommitting the license value would probably mean your data would not be incorporated into the distribution metadata. Permissible license codes include:

        CC0-1.0
        CC-BY-3.0
        CC-BY-SA-3.0
        GFDL-1.3
        MIT

    The license codes correspond to the identifiers found at the SPDX OpenSource License Registry. Take a look at <metadata_license/> for more details about this tag.


The program is GPL v3 or above, but they are specifically saying to use different license terms for this metadata file.

@Orion, since you do more packaging for mainstream distributions like Fedora, is there a standard license type that other GNU projects use?


Rik <rik5>
Group administrator
Fri 13 Jan 2017 02:59:48 PM UTC, comment #3: 


> I was looking at this specification: https://people.freedesktop.org/~hughsient/appdata/.


That is not the specification. This is what we were told before when treating that as the specification "What you are referring to is not the documentation - it is what Richard wrote initially before we added it to the official documentation at https://www.freedesktop.org/software/appstream/docs/"

Carnë Draug <carandraug>
Group Member
Thu 12 Jan 2017 04:46:12 AM UTC, comment #2: 

I would assume so, since that's what the docs indicate.  Apparently though there must be some backwards compatibility going on.

$ appstream-util validate /usr/share/appdata/www.octave.org-octave.appdata.xml
/usr/share/appdata/www.octave.org-octave.appdata.xml: FAILED:
• tag-invalid           : <metadata_license> is not valid [GPLv3+]
• url-not-found         : <screenshot> url not found http://www.gnu.org/software/octave/images/screenshot.png

so it seems to translate <license> to <metadata_license>.  Looks there is an issue with the screenshot url as well.

Also, instead of:
<application>
 <id type="desktop">/path/to/desktopfile</id>

the docs now have:

<component type="desktop">
 <id>gnome-power-statistics.desktop</id>

but again, the validate tool isn't complaining.  Ah, but in strict mode:

$ appstream-util validate-strict /usr/share/appdata/www.octave.org-octave.appdata.xml
/usr/share/appdata/www.octave.org-octave.appdata.xml: FAILED:
• tag-invalid           : <metadata_license> is not valid [GPLv3+]
• tag-missing           : <project_license> is not present
• value-missing         : <!-- Copyright [year] [name] --> is not present
• url-not-found         : <screenshot> url not found http://www.gnu.org/software/octave/images/screenshot.png
• translations-required  : <name> has no translations
• translations-required  : <summary> has no translations
• translations-required  : <description> has no translations
• attribute-invalid     : <licence> is deprecated, use <metadata_license> instead

Orion Poplawski <opoplawski>
Thu 12 Jan 2017 04:14:35 AM UTC, comment #1: 

Shouldn't the field "licence" also be changed to "project_license"?  I was looking at this specification: https://people.freedesktop.org/~hughsient/appdata/.

Rik <rik5>
Group administrator
Thu 29 Dec 2016 04:36:23 PM UTC, original submission:  

https://bugzilla.redhat.com/show_bug.cgi?id=1293561

--- Comment #13 from Kalev Lember <klember@redhat.com> ---
I looked at why octave isn't still showing up in the appstream metadata and apparently it's now erroring out because the <license> isn't a valid SPDX license:

AppData
./tmp/fedora-26/octave-4.2.0-11.fc26/usr/share/appdata/www.octave.org-octave.appdata.xml
license 'GPLv3+' invalid

+--- octave-4.2.0/etc/icons/octave.appdata.xml.in.appdata 2016-11-13 16:16:10.000000000 +0100
++++ octave-4.2.0/etc/icons/octave.appdata.xml.in 2016-12-29 14:54:32.389932341 +0100
+@@ -17,7 +17,7 @@
+ -->
+ <application>
+   <id type="desktop">%OCTAVE_DESKTOP_FILE%</id>
+-  <licence>GPLv3+</licence>
++  <licence>GPL-3.0+</licence>
+   <name>GNU Octave</name>
+   <summary>Interactive programming environment for numerical computations</summary>
+   <description>

Orion Poplawski <opoplawski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #39470:  appdata.cset added by rik5 (2KiB - application/octet-stream)
file #39471:  octave.appdata.xml added by rik5 (3KiB - text/xml)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by opoplawski (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-13 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2017-01-13 rik5 StatusNeed Info Ready For Test
    2017-01-13 rik5 Attached File- Added appdata.cset, #39470
        Attached File- Added octave.appdata.xml, #39471
    2017-01-12 rik5 StatusPatch Submitted Need Info
    2016-12-29 siko1056 Severity3 - Normal 4 - Important
        Priority5 - Normal 7 - High
        StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code