bugGNU Octave - Bugs: bug #45258, mpi-1.2.0 build fails in Octave...

 
 

bug #45258: mpi-1.2.0 build fails in Octave 4.0.0

Submitter:  Julien Bect <jbect>
Submitted:  Fri 05 Jun 2015 11:35:06 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  cdf
Originator Name:  Open/Closed:  * Closed
Release:  * 4.0.0 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 16 May 2016 05:09:51 PM UTC, comment #11: 


> I do not see other ways of "failing gracefully" ...


I don't know, perhaps can it be achieved through the Dependencies fields in DESCRIPTION?

Or perhaps using a preprocessor directive such as

#if defined (DEFINE_OCTAVE_ALLOCATOR)
#error BLAH BLAH BLAH
#fi

?

Julien Bect <jbect>
Mon 16 May 2016 05:06:30 PM UTC, comment #10: 

some things will definitely not work in 4.0.2, e.g. sending/receiving scalar structures and cell arrays.

what about bumping the Octave dependecy to 4.1 so that
it won't install in 4.0?

I do not see other ways of "failing gracefully" ...


Carlo de Falco <cdf>
Group Member
Mon 16 May 2016 04:37:40 PM UTC, comment #9: 

Well, I have no idea if it "works reasonably" in 4.0.2.

But currently it cannot even be installed, and installation fails with a rather cryptic error message (see my initial post)...

Is there any reason to believe that it doesn't work in 4.0.2?

Is there a test suite that I could run to know about that?

If it cannot be made to run in 4.0.x soon, perhaps should you consider a 1.2.1 release that simply fails more gracefully when a user tries to install it from 4.0.x?

Julien Bect <jbect>
Mon 16 May 2016 02:39:49 PM UTC, comment #8: 

There's more issues that need fixing for making MPI
portable to Octave 4.2, e.g. bug #45294 .

I did not plan to support both 4.0.x and 4.2 versions,
but if you think the version currently in the repository
works reasonably in 4.0.2 and is worth releasing we could
make a release right now.


Carlo de Falco <cdf>
Group Member
Mon 16 May 2016 08:40:31 AM UTC, comment #7: 

The patch has been applied in august 2015 and the bug report has been closed...

But there has been no release of package mpi since then, so the problem still exists for people that install the package using "pkg install -forge mpi"

:-(

Julien Bect <jbect>
Wed 09 Sep 2015 10:22:28 PM UTC, comment #6: 

@Carlo
It seems that the patch is not available any more. I found the same problem but I couldn't find the patch.
Best
Luiz

Luiz Carvalho <luizmc>
Mon 17 Aug 2015 05:23:34 PM UTC, comment #5: 

I applied the patch with preprocessing directives as suggested.
thanks,
c.

Carlo de Falco <cdf>
Group Member
Mon 08 Jun 2015 07:56:41 AM UTC, comment #4: 

@Carlo: perhaps should you use preprocessing directives, as Mike Miller did for the communications package, for the sake of backward compatibility ?

http://sourceforge.net/p/octave/communications/ci/dd3e0dc1cd053909153fb03e5c79dc19f6068f4a/

Julien Bect <jbect>
Mon 08 Jun 2015 07:53:21 AM UTC, comment #3: 

---- Posting here reply to Michael Creel on the mailing list

>> Carlo, that patch solved the problem.


OK, thanks for testing, so I'll apply the pacth and prepare a release.

>> I can't log into the bug tracker
>> (though I have not changed my password) so I have not added a
>> comment there.


Even though you have not changed your password you may want to try "[Lost your password?]"
on the login screen to recover your account info on savannah, although unlikely, it may be
that someone guessed your password and changed it ...

>> One other note, the mc_example.m in the inst directory of the
>> mpi package
>> does not run with Octave v4.0. If the olswrapper function is
>> pulled out and
>> put in a separate file, the example will run.


I'll look into this before the release but at first sight this sounds like an interpreter
bug rather than a problem with the mpi package ...


Carlo de Falco <cdf>
Group Member
Fri 05 Jun 2015 04:14:53 PM UTC, comment #2: 

I don't have a working installation of Octave 4.0
but the fix should be trivial, can you try the attached patch?

c.

(file #34166)

Carlo de Falco <cdf>
Group Member
Fri 05 Jun 2015 02:21:22 PM UTC, comment #1: 

adding maintainer of the mpi package

Carnë Draug <carandraug>
Group Member
Fri 05 Jun 2015 11:35:06 AM UTC, original submission:  

mpi-1.2.0 build fails in Octave 4.0.0

The problem is similar to

https://savannah.gnu.org/bugs/?func=detailitem&item_id=44063

Here is the log:


>> pkg install -forge mpi
In file included from MPI_Comm_size.cc:26:0:
simple.h:42:3: error: ‘DECLARE_OCTAVE_ALLOCATOR’ does not name a type
   DECLARE_OCTAVE_ALLOCATOR;
   ^
simple.h:47:33: error: expected constructor, destructor, or type conversion before ‘;’ token
 DEFINE_OCTAVE_ALLOCATOR (simple);
                                 ^
In file included from MPI_Comm_rank.cc:26:0:
simple.h:42:3: error: ‘DECLARE_OCTAVE_ALLOCATOR’ does not name a type
   DECLARE_OCTAVE_ALLOCATOR;
   ^
simple.h:47:33: error: expected constructor, destructor, or type conversion before ‘;’ token
 DEFINE_OCTAVE_ALLOCATOR (simple);
                                 ^
make: *** [MPI_Comm_size.oct] Error 1
make: *** Attente des tâches non terminées....
make: *** [MPI_Comm_rank.oct] Error 1
make: Entering directory '/tmp/oct-jUFfjQ/mpi/src'
/usr/local/bin/mkoctfile-4.0.0 -I/usr/lib/openmpi/include -I/usr/lib/openmpi/include/openmpi -lpthread   -L/usr//lib -L/usr/lib/openmpi/lib -lmpi_cxx -lmpi -ldl -lhwloc MPI_Init.cc
/usr/local/bin/mkoctfile-4.0.0 -I/usr/lib/openmpi/include -I/usr/lib/openmpi/include/openmpi -lpthread   -L/usr//lib -L/usr/lib/openmpi/lib -lmpi_cxx -lmpi -ldl -lhwloc MPI_Initialized.cc
/usr/local/bin/mkoctfile-4.0.0 -I/usr/lib/openmpi/include -I/usr/lib/openmpi/include/openmpi -lpthread   -L/usr//lib -L/usr/lib/openmpi/lib -lmpi_cxx -lmpi -ldl -lhwloc MPI_Comm_rank.cc
/usr/local/bin/mkoctfile-4.0.0 -I/usr/lib/openmpi/include -I/usr/lib/openmpi/include/openmpi -lpthread   -L/usr//lib -L/usr/lib/openmpi/lib -lmpi_cxx -lmpi -ldl -lhwloc MPI_Comm_size.cc
Makefile:24: recipe for target 'MPI_Comm_size.oct' failed
Makefile:24: recipe for target 'MPI_Comm_rank.oct' failed
make: Leaving directory '/tmp/oct-jUFfjQ/mpi/src'

pkg: error running `make' for the mpi package.
error: called from 'configure_make' in file /usr/local/share/octave/4.0.0/m/pkg/private/configure_make.m near line 96, column 9


Julien Bect <jbect>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #34167:  open_cidefi87.txt added by cdf (909B - text/plain - patch version 2)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by luizmc (Posted a comment)
  • -email is unavailable- added by svillemot
  • -email is unavailable- added by cdf (Updated the item)
  • -email is unavailable- added by carandraug (Carlo de Falco - maintainer of the mpi package)
  • -email is unavailable- added by jbect (Submitted the item)
  • -email is unavailable- added by jbect
  • -email is unavailable- added by jbect
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-08-17 cdf StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2015-07-21 svillemot Carbon-Copy- Added svillemot
    2015-06-05 cdf Attached File- Added open_cidefi87.txt, #34167
    2015-06-05 cdf Attached File#34166 Removed
    2015-06-05 cdf Attached File- Added open_2rGer310.txt, #34166
        StatusNone Patch Submitted
        Assigned toNone cdf
    2015-06-05 carandraug Carbon-Copy- Added -email is unavailable-
    2015-06-05 jbect Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code