bugGNU Wget - Bugs: bug #28777, Wget -c fails to re-download files...

 
 

bug #28777: Wget -c fails to re-download files that lack Content-Length

Submitter:  Micah Cowan <micahcowan>
Submitted:  Sat 30 Jan 2010 05:33:18 PM UTC
   
 
Category:  Program Logic Severity:  4 - Important
Priority:  7 - High Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  1.12 Operating System:  None
Reproducibility:  None Fixed Release:  1.12.1
Planned Release:  1.12.x Regression:  Yes
Work Required:  None Patch Included:  Yes
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 20 Jul 2010 05:44:42 PM UTC, comment #2: 

I have pushed the patch with the commit 2407.

Giuseppe Scrivano <gscrivano>
Group administrator
Sat 30 Jan 2010 06:13:18 PM UTC, comment #1: 

Note: the fix itself is trivial, and should not require papers. Get papers for the other changes (if they seem appropriate), and for the test supplied for the fix.

Micah Cowan <micahcowan>
Sat 30 Jan 2010 05:33:18 PM UTC, original submission:  

http://article.gmane.org/gmane.comp.web.wget.general/9197


    Fix regression (Test-c-partial-no-content-length)
    Rev 4318b1cccf8e "Don't download content just to ignore it."
    caused "wget -c" to fail on resources without Content-Length,
    saying "The file is already fully retrieved; nothing to do."

    Fix it by checking content-length was set before trying to
    compare it with the already downloded filesize.

The above fix is available to be pulled (along with a test case) with

hg pull -r 9e9c63037f9f https://sourcejedi <at> bitbucket.org/sourcejedi/wget-aj/

[Note the -r switch!].

I have also implemented support for transparent decompression
(Content-Encoding: gzip).  This is based on the regression fix; the
combined changes are available with

hg pull https://sourcejedi <at> bitbucket.org/sourcejedi/wget-aj/

and the commits can also be browsed online at
<http://bitbucket.org/sourcejedi/wget-aj/>


Waiting for assignment papers.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gscrivano (Posted a comment)
  • -email is unavailable- added by micahcowan (Submitted the item)
  •  

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-20 gscrivano StatusReady for Merge Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone 1.12.1
    2010-01-30 micahcowan StatusAwaiting Approval Ready for Merge
    2010-01-30 micahcowan Priority5 - Normal 7 - High

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code