bugmake - Bugs: bug #27590, MSVC Win64 build patch

 
 

bug #27590: MSVC Win64 build patch

Submitter:  None
Submitted:  Sun 04 Oct 2009 09:08:33 AM UTC
   
 
Severity:  3 - Normal Item Group:  Build/Install
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.0 Operating System:  MS Windows
Fixed Release:  3.82 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 12 Jul 2010 08:33:33 PM UTC, comment #5: 

Applied.

Paul D. Smith <psmith>
Group administrator
Mon 12 Jul 2010 07:09:31 PM UTC, comment #4: 

I don't care about the MSVC compiler, I use only GCC.  Go ahead and commit this, and if it breaks the GCC build, I will handle it in the next RC.

Eli Zaretskii <eliz>
Group Member
Mon 12 Jul 2010 06:03:21 PM UTC, comment #3: 

Hi Eli; do you have any thoughts on this change?  Is this something we should take?

Paul D. Smith <psmith>
Group administrator
Sun 04 Oct 2009 08:27:22 PM UTC, comment #2: 

Two changes were made:

1) Removed /MACHINE:I386 option from link commands.
   This option is not necessary and will be automatically set
   by the linker. I've tested okay with WIN32 after the change.

2) Protected the offending 'int execve ()' line with
   '#if !(defined(_MSC_VER) && defined(_WIN64))' which means
   it will not harm WIN32 mode or non-MSVC compilers. It will
   only be effective for MSVC compilers in Win64 mode, both
   x86-64 and IA-64 architectures.
   For the fun of it I've tested with Itanium also, and the
   patch makes it work as well.

Brgds,
Viktor

Anonymous
Sun 04 Oct 2009 09:39:15 AM UTC, comment #1: 

Can you please give a short explanation for each change?

Also, are you sure the first of these changes doesn't harm the Win32 build in any way?  (I don't have MSVC installed to try this myself.)

Thanks.

Eli Zaretskii <eliz>
Group Member
Sun 04 Oct 2009 09:08:33 AM UTC, original submission:  

Hi All,

Pls find attached patch which fixes two minor bugs which prevented MSVC Windows x86_64 builds to succeed. Tested with MSVC 2008.

Brgds,
Viktor Szakats

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #18811:  win64.dif added by None (6KiB - video/x-dv)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by eliz (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-28 psmith Fixed Release4.0 3.82
    2010-07-12 psmith StatusNone Fixed
        Assigned toeliz psmith
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.0
    2010-07-12 psmith Assigned toNone eliz
    2009-10-04 None Attached File- Added win64.dif, #18811

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code