bugmake - Bugs: bug #9748, unguarded tempnam: gmake crashes...

 
 

bug #9748: unguarded tempnam: gmake crashes when build with BolandC

Submitted by:  Alessandro Vesely <ale2003>
Submitted on:  Sat 24 Jul 2004 03:53:01 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 3.80Operating System: Any
Fixed Release: 3.81Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 06 Oct 2004 01:08:20 PM UTC, comment #2:

Thanks for signing papers for your changes Alessandro!
This patch has been applied and will appear in the next release. I did not apply the streq/strieq change, though, since there seemed to be some debate about whether it was appropriate.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Sun 25 Jul 2004 09:15:41 AM UTC, comment #1:

Ooops, the first patch had the side effect to leave empty
files without extension in the current directory.

Please discard the previous patch and consider the new one instead. It contains a new function that guarantees the
uniqueness of the name-with-extension and therefore is more
convenient than MSVC's tempnam, for WINDOWS32.

Alessandro Vesely <ale2003>
Sat 24 Jul 2004 03:53:01 PM UTC, original submission:

tempnam can return NULL, template should be short (5 chars),
usually deprecated, it is used only for Win32 batch files.

The patch proposed is not particularly brilliant, as it uses
Win32's GetTempFileName() and thus creates files like e.g.
"C:\current\dir\mak2104.TMP.bat", see MS docs for more
http://msdn.microsoft.com/library/en-us/fileio/base/gettempfilename.asp

The patch also contains two unrelated changes: the first is
a (HANDLE) cast I needed to make the compiler happy, whilst
the second is a 's/streq/strieq/' so that one can write
"ECHO blah" when HAVE_CASE_INSENSITIVE_FS is defined. All
that apparently works, but I didn't test it thoroughly.

Alessandro Vesely <ale2003>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #1590:  job.c.patch added by ale2003 (4KiB - application/octet-stream - A somewhat better patch to job.c)
file #1588:  job.c.patch added by ale2003 (1KiB - application/octet-stream - Possible patch to job.c)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 7 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 01 Apr 2006 07:11:30 AM UTCpsmithFixed Release4.0=>3.81
Wed 06 Oct 2004 01:08:20 PM UTCpsmithStatusNone=>Fixed
  Assigned toNone=>psmith
  Open/ClosedOpen=>Closed
  Fixed ReleaseNone=>4.0
Sun 25 Jul 2004 09:15:41 AM UTCale2003Attached File-=>Added job.c.patch, #1523
Sat 24 Jul 2004 03:53:01 PM UTCale2003Attached File-=>Added job.c.patch, #1521

Back to the top


Powered by Savane 3.1-cleanup1