bugphpGroupWare - Bugs: bug #8975, bug in building sql-query (Better...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #8975: bug in building sql-query (Better one whitespace too much than too few...)

Submitted by:  Matthias Leonhardt <mleonhardt>
Submitted on:  Sun 16 May 2004 09:14:30 AM UTC  
 
Item Group: 0.9.16.000 releaseCategory: calendar
Severity: 3 - NormalPriority: 5 - Normal
Status: FixedPrivacy: Public
Assigned to: Dave Hall <skwashd>Open/Closed: Closed
Component Version: SVNOperating System: GNU/Linux - Debian
Reproducibility: NonePlanned Release: None
Fixed Release: 

Sun 16 May 2004 11:07:06 AM UTC, comment #1:

Fixed in 16 cvs. The patch in its provided form was not usable.

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Sun 16 May 2004 09:14:30 AM UTC, original submission:

Index: class.socalendar_sql.inc.php
===================================================================
RCS file: /cvsroot/phpgroupware/calendar/inc/class.socalendar_sql.inc.php,v
retrieving revision 1.28.2.4.2.8
diff -u -r1.28.2.4.2.8 class.socalendar_sql.inc.php
--- class.socalendar_sql.inc.php 12 Sep 2003 02:16:22 -0000
1.28.2.4.2.8
+++ class.socalendar_sql.inc.php 14 May 2004 15:14:56 -0000
@@ -827,7 +826,7 @@
$lastmod = intval($lastmod);
$repeats = (bool) $repeats;

- $user_where = " AND phpgw_cal_user.cal_login = $this->user";
+ $user_where = " AND phpgw_cal_user.cal_login = $this->user ";

$member_groups =
$GLOBALS['phpgw']->accounts->membership($this->user);
@reset($member_groups);
@@ -846,9 +845,9 @@

if($lastmod > 0)
{
- $wheremod = "AND mdatetime = $lastmod";
+ $wheremod = " AND mdatetime > $lastmod";
}
-
+
$order_by = ' ORDER BY phpgw_cal.cal_id ASC';
if($this->debug)
{

Matthias Leonhardt <mleonhardt>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sun 16 May 2004 11:07:06 AM UTCskwashdStatusNone=>Fixed
  Assigned toalexbsa=>skwashd
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1