bugGNUstep - Bugs: bug #8654, forwarding sometimes fails

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #8654: forwarding sometimes fails

Submitted by:  Willem Rein Oudshoorn <wim>
Submitted on:  Thu 22 Apr 2004 12:26:52 PM UTC  
 
Category: Base/FoundationSeverity: 2 - Minor
Item Group: BugStatus: None
Privacy: PublicAssigned to: Willem Rein Oudshoorn <wim>
Open/Closed: Closed

Mon 26 Apr 2004 07:48:53 AM UTC, comment #2:

As pointed out by David Ayers, it should also
be fixed in GSFFIInvocation.m

Willem Rein Oudshoorn <wim>
Project MemberIn charge of this item.
Thu 22 Apr 2004 12:49:06 PM UTC, comment #1:

This patch fixes these problems.
If no one objects, I will apply this patch shortly.

Willem Rein Oudshoorn <wim>
Project MemberIn charge of this item.
Thu 22 Apr 2004 12:26:52 PM UTC, original submission:

There are two issues, one cosmetic and the other
quite annoying.

  • Cosmetic: In the function: GSInvocationCallback,

defined in GSFFCallInvocation.m, towards the end there
is code to throw the exception:
[NSException raise: NSInvalidArgumentException
format: @"%s(%s) does not recognize %s",
However, this is misleading. We are in the forwarding
code, so the target obviously does not recognize
the selector. It should say:
@"Can not determine type information for selector %s"
or something like that.

  • More serious issue:

The forwarding code gives up too easily. If
the selector does not have type information it should
look for an equivalent selector with type information.
(Preferably it should check if there exist conflicting
type information.)
The problem for not having the right type information
is shown with the attached program.

[object notRecognizedSelector]

is forwarded correctly. However:

[object performSelector: @selector (notRecognizedSelector)]

will throw an exception.

Willem Rein Oudshoorn <wim>
Project MemberIn charge of this item.

 

Attached Files
file #1234:  GSFFCallInvocation.patch added by wim (872B - application/octet-stream - Patch for GSFFcallInvocation that fixes the forwarding problem)
file #1233:  testForwarding.m added by wim (591B - application/octet-stream - Program that shows that forwarding can fail.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 26 Apr 2004 07:54:47 AM UTCwimOpen/ClosedOpen=>Closed
Mon 26 Apr 2004 07:48:53 AM UTCwimAssigned toNone=>wim
Thu 22 Apr 2004 12:49:07 PM UTCwimAttached File-=>Added GSFFCallInvocation.patch, #1218
Thu 22 Apr 2004 12:26:52 PM UTCwimAttached File-=>Added testForwarding.m, #1217

Back to the top


Powered by Savane 3.1-cleanup1