bugGNU FreeIPMI - Bugs: bug #8414, Poor handling of values that can...

 
 

bug #8414: Poor handling of values that can only be set on certain platforms

Submitted by:  Joseph Ruscio <jruscio>
Submitted on:  Thu 01 Apr 2004 05:33:27 PM UTC  
 
Category: bmc-configSeverity: 3 - Normal
Priority: 5 - NormalItem Group: User Interface Bug
Status: Wont FixPrivacy: Public
Assigned to: Anand Babu <ab>Open/Closed: Closed
Operating System: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 15 Apr 2004 08:38:21 AM UTC, comment #5:

Current error handler is good enough. Discussed on the mailing list.

Anand Babu <ab>
Project AdministratorIn charge of this item.
Tue 13 Apr 2004 06:38:45 PM UTC, comment #4:

I think we should try and do user-level checks to make sure values are as correct as can be. For example:

tdev3|/home/achur 116>/usr/sbin/bmc-config --diff -f conf-new
BMC: callback_level.max_privilege_auth_type.none 0
USER: callback_level.max_privilege_auth_type.none 9

tdev3|/home/achur 117>/usr/sbin/bmc-config --commit -f conf-new

We can atleast check that user has input 0 or 1.

Albert Chu <chu11>
Project Administrator
Tue 06 Apr 2004 12:22:31 AM UTC, comment #3:

I didn't expect that we could determine exact ranges, I just don't like seeing libfreeipmi function names in user level error messages. So yes, it is simply a matter of style.

Joseph Ruscio <jruscio>
Mon 05 Apr 2004 11:32:02 PM UTC, comment #2:

IPMI Spec doesn't define valid input range clearly for all settable parameters.

BMC can only try the user fed value and see if BMC returns
"Invalid Data" error code.

I think main argument is about beautifying error messages.
It is a matter of policy and style :).

Anand Babu <ab>
Project AdministratorIn charge of this item.
Mon 05 Apr 2004 11:21:46 PM UTC, comment #1:

Current error handler is generic and can exactly translate BMC's error response code to some meaningful English text like "Invalid data field in Request". Actual possibilities are huge.

Anand Babu <ab>
Project AdministratorIn charge of this item.
Thu 01 Apr 2004 05:33:27 PM UTC, original submission:

The file containg the current configuration of the BMC output from executing contains a comment for each option, listing all acceptable values.

Many of the configuration options do not accept all of the values listed in the comments. I assume this is a platform specific situation. Currently attmpeting to set these values result in errors of the following types:

error: ipmi_kcs_set_user_access: 204: Invalid data field in Request.

error: ipmi_lan_set_ip_addr_source: 204: Invalid data field in Request.

These are cryptic and should be replaced with something similar to this:

"Unable to set requested <KEY> to <VALUE> either due to specific platform restrictions or value being invalid."

Joseph Ruscio <jruscio>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Thu 15 Apr 2004 08:38:21 AM UTCabStatusNone=>Wont Fix
  Assigned toNone=>ab
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1