bugXnee - Bugs: bug #8324, --retype-file option for cnee does...

 
 

bug #8324: --retype-file option for cnee does not set mode

Submitted by:  Joseph Miele <jemiele1>
Submitted on:  Sat 27 Mar 2004 08:07:13 AM UTC  
 
Category: cneeSeverity: 3 - Normal
Item Group: Error reportStatus: Fixed
Privacy: PublicAssigned to: Henrik Sandklef <hesa>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 30 Mar 2004 07:33:19 PM UTC, comment #1:

Yes, this is the way to do it. Will include it.....

Henrik Sandklef <hesa>
Project AdministratorIn charge of this item.
Sat 27 Mar 2004 08:07:13 AM UTC, original submission:

Problem: Option "--retype-file" fails to set the mode, causing the option to fail.

Version affected: CVS

Steps to reproduce the bug:
1. Create text file /tmp/test.xnee. The contents of the file do not matter.
2. Enter the following command:
cnee --verbose --retype-file /tmp/test.xnee

One of the lines of the verbose output will be: "No mode specified... leaving".

Cause: Missing call to xnee_set_retyper in file parse.c (directory cnee/src)

Here is the corrected code segment for parse.c:

else if(xnee_check(argv[i], "--retype-file", "-rtf" ))
{
xnee_set_retyper(xd); /* this is the fix */
if (++i >= argc)
{
xnee_usage(stderr);
xnee_close_down(xd);
exit(XNEE_WRONG_PARAMS);
}
if ( xnee_set_rt_name (xd, argv[i]) != XNEE_OK)
{
xnee_print_error ("Unable to open retype file\n");
xnee_verbose ((xd, "Could not open retype file\n"));
xnee_verbose ((xd, "... leaving\n"));
xnee_close_down(xd);
exit(XNEE_WRONG_PARAMS);
}
continue;

}

Notice the new line designated as the fix. Adding this line solved the problem for me. Running cnee as indicated in step 2 works correctly with this change in place.

Please review this code change. If you find the fix acceptable, please update CVS.

Thank you for your time.

Joseph Miele <jemiele1>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sun 18 Apr 2004 08:49:11 PM UTChesaStatusNone=>Fixed
  Assigned toNone=>hesa
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1