bugDotGNU Portable.NET - Bugs: bug #8208, #endregion tokenisation not...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #8208: #endregion tokenisation not compatible with VS

Submitted by:  Russell Stuart <rstuart>
Submitted on:  Fri 19 Mar 2004 01:53:16 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Fri 07 May 2004 05:55:55 PM UTC, comment #6:

patch applied.

Russell Stuart <rstuart>
Project Member
Fri 02 Apr 2004 08:07:54 AM UTC, comment #5:

This patch makes cscc give errors on the same lines as csc, although the messages are different.

Russell Stuart <rstuart>
Project Member
Wed 24 Mar 2004 02:42:10 AM UTC, comment #4:

Re VS ignoring everything after the #endregion - so does PNet. Its just the ; that confuses it. Hence the bug title - I suspect the tokenisation of the # directives is at fault - it is including the ';' in the #endregion token. If it regarded the ; as a separate token all would be OK.

Russell Stuart <rstuart>
Project Member
Tue 23 Mar 2004 05:23:09 PM UTC, comment #3:

#region int asd ljasljd ljasljd ljasdlj jkahsf lakhsdfl
#endregion int asjhdkahsd ksakd kasd laskjd las

it appears the VS compiler ignores everything after the directive to line end as the snippet above is valid.

Anonymous
Sat 20 Mar 2004 02:14:04 AM UTC, comment #2:

The comments I added to the other bug apply equally well here. Sorry for the repetition ...

The code containing construct this does compile under VS. I have verified this. I have a copy of VS. Before submitting the bug I put the example given in a file called x.cs, and compiled it. I did not pass the compiler any special switches. As the original buig report says, VS did not give any errors or warnings.

I am reporting this because I am in the process of porting NUnit to PNet. NUnit was obviously developed under VS. It contains a more complex version of the code submitted.

Its not really about being technically right or wrong. Its about being compatible with MS's implementation of C#. I don't know if that is one of PNet's goals, but I thought I would submit it anyway. If it is not one I PNet's goals I can always submit a patch to NUnit.

Let me know what the decision is.

Russell Stuart <rstuart>
Project Member
Fri 19 Mar 2004 04:30:45 PM UTC, comment #1:

#endregion;

Extra semicolon ?

Gopal.V <t3rmin4t0r>
Project Administrator
Fri 19 Mar 2004 01:53:16 PM UTC, original submission:

This code compiles under VS without errors or warnings. It does not compile under VS.

class X {
#region
#endregion;
}

Russell Stuart <rstuart>
Project Member

 

Attached Files
file #1167:  endregion.patch added by rstuart (656B - application/octet-stream - diff -Nur)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 07 May 2004 06:13:29 PM UTCrstuartOpen/ClosedOpen=>Closed
Fri 07 May 2004 05:55:55 PM UTCrstuartStatusNone=>Fixed
Fri 02 Apr 2004 08:07:54 AM UTCrstuartAttached File-=>Added endregion.patch, #1149

Back to the top


Powered by Savane 3.1-cleanup1