bugXnee - Bugs: bug #8149, Problems with --retype file option.

 
 

bug #8149: Problems with --retype file option.

Submitted by:  Joseph Miele <jemiele1>
Submitted on:  Mon 15 Mar 2004 05:32:07 PM UTC  
 
Category: XneeSeverity: 3 - Normal
Item Group: Error reportStatus: Fixed
Privacy: PublicAssigned to: Henrik Sandklef <hesa>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 18 Mar 2004 06:26:24 PM UTC, comment #1:

Fixed on my laptop. Will sync it to CVS asap.

Thanks for your report and the helping text

Henrik Sandklef <hesa>
Project AdministratorIn charge of this item.
Mon 15 Mar 2004 05:32:07 PM UTC, original submission:

Problem # 1: The --time option is ignored when using option --retype-file. The contents of the file are typed immdiately.

Problem #2: The auto key repeat in X is disabled after running xnee with the --retype-file option.

Possible cause: After reviewing the code, I noticed that file parse.c calls subroutine xnee_type_file, ostensibly to verify that the file to be retyped exists. However, this call to the file does more than simply verify the existence of the file. It actually performs the file retyping during the parsing of the command line arguments! By performing the file retyping from parse.c, the --time argument is ignored, which results in problem #1. In addition, subroutine xnee_type_file does not terminate with a return statement, but with an exit! Since xnee_type_file calls xnee_set_autorepeat, but does NOT call xnee_reset_autorepeat, the auto key repeat in X is disabled and never reset! This results in problem #2.

Possible solution: File parse.c needs to be changed so it doesn't call subroutine xnee_file_type to verify if the file to be retyped exists. It needs to store the file name in structure xnee_data, so subroutine xnee_type_file can reference it later. Then subroutine xnee_type_file needs to be changed so it does not call xnee_set_autorepeat and so it does not terminate with an exit, but with a return. This will allow it to function like other subroutines so options such as --time will be processed.

I can make these changes, but I am hesitant to do so. Before doing anything, I thought I would submit these problems (and my ideas for a solution) here first. After all, you know this code better than I do. :-)

Joseph Miele <jemiele1>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Thu 18 Mar 2004 06:26:24 PM UTChesaStatusNone=>Fixed
  Assigned toNone=>hesa
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1