bugClasspath Extensions - Bugs: bug #7937, String comparisons that use == or...

 
 

bug #7937: String comparisons that use == or != instead of equals()

Submitted by:  None
Submitted on:  Sun 29 Feb 2004 03:03:23 AM UTC  
 
Category: NoneSeverity: 4 - Important
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Arnaud Vandyck <avdyk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 14 Apr 2004 11:17:25 PM UTC, comment #3:

'==' is used if SAXDriver feature "http://xml.org/sax/features/string-interning is set to true (default); else, 'equals' is used.

Arnaud Vandyck <avdyk>In charge of this item.
Tue 06 Apr 2004 06:20:38 AM UTC, comment #2:

I got to revert the patch because it's not a bug!
The Strings are internal so the comparaison is faster than the equals() method.

Arnaud Vandyck <avdyk>In charge of this item.
Sat 06 Mar 2004 09:18:16 PM UTC, comment #1:

First of all, thanks for the audit.

I did change these files:
gnu/xml/aelfred2/SAXDriver.java, gnu/xml/aelfred2/XmlParser.java, gnu/xml/pipeline/DomConsumer.java, gnu/xml/pipeline/ValidationConsumer.java, gnu/xml/pipeline/WellFormednessFilter.java, gnu/xml/util/XCat.java.

In some case, it seems it's not a bug but a way to be faster. Anyway. If someone disagree with the changes, I can revert them back.

Arnaud Vandyck <avdyk>In charge of this item.
Sun 29 Feb 2004 03:03:23 AM UTC, original submission:

The following lines of the JAXP implementation perform comparisons with String literals using == or != instead of equals(). This is not guaranteed to produce the proper results when the Strings are equal but not the exact same object.

gnu/xml/aelfred2/SAXDriver.java 747
gnu/xml/aelfred2/SAXDriver.java 817
gnu/xml/aelfred2/SAXDriver.java 1003

gnu/xml/aelfred2/XmlParser.java 1106
gnu/xml/aelfred2/XmlParser.java 1517
gnu/xml/aelfred2/XmlParser.java 1544
gnu/xml/aelfred2/XmlParser.java 1547
gnu/xml/aelfred2/XmlParser.java 1548
gnu/xml/aelfred2/XmlParser.java 1549
gnu/xml/aelfred2/XmlParser.java 1550
gnu/xml/aelfred2/XmlParser.java 1551
gnu/xml/aelfred2/XmlParser.java 1552
gnu/xml/aelfred2/XmlParser.java 1553
gnu/xml/aelfred2/XmlParser.java 1554
gnu/xml/aelfred2/XmlParser.java 1634
gnu/xml/aelfred2/XmlParser.java 1658
gnu/xml/aelfred2/XmlParser.java 1660
gnu/xml/aelfred2/XmlParser.java 3194
gnu/xml/aelfred2/XmlParser.java 3195
gnu/xml/aelfred2/XmlParser.java 3459

gnu/xml/pipeline/DomConsumer.java 662

gnu/xml/pipeline/ValidationConsumer.java 658
gnu/xml/pipeline/ValidationConsumer.java 660
gnu/xml/pipeline/ValidationConsumer.java 704
gnu/xml/pipeline/ValidationConsumer.java 707
gnu/xml/pipeline/ValidationConsumer.java 711
gnu/xml/pipeline/ValidationConsumer.java 722
gnu/xml/pipeline/ValidationConsumer.java 726
gnu/xml/pipeline/ValidationConsumer.java 729
gnu/xml/pipeline/ValidationConsumer.java 739
gnu/xml/pipeline/ValidationConsumer.java 758
gnu/xml/pipeline/ValidationConsumer.java 1023
gnu/xml/pipeline/ValidationConsumer.java 1035
gnu/xml/pipeline/ValidationConsumer.java 1043
gnu/xml/pipeline/ValidationConsumer.java 1058
gnu/xml/pipeline/ValidationConsumer.java 1069
gnu/xml/pipeline/ValidationConsumer.java 1090
gnu/xml/pipeline/ValidationConsumer.java 1096
gnu/xml/pipeline/ValidationConsumer.java 1112
gnu/xml/pipeline/ValidationConsumer.java 1121
gnu/xml/pipeline/ValidationConsumer.java 1168

gnu/xml/pipeline/WellFormednessFilter.java 225
gnu/xml/pipeline/WellFormednessFilter.java 238
gnu/xml/pipeline/WellFormednessFilter.java 249
gnu/xml/pipeline/WellFormednessFilter.java 261

gnu/xml/util/XCat.java 1262
gnu/xml/util/XCat.java 1323
gnu/xml/util/XCat.java 1334
gnu/xml/util/XCat.java 1343
gnu/xml/util/XCat.java 1350
gnu/xml/util/XCat.java 1370
gnu/xml/util/XCat.java 1397
gnu/xml/util/XCat.java 1423
gnu/xml/util/XCat.java 1449
gnu/xml/util/XCat.java 1475
gnu/xml/util/XCat.java 1500
gnu/xml/util/XCat.java 1524
gnu/xml/util/XCat.java 1548
gnu/xml/util/XCat.java 1560

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 8 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 14 Apr 2004 11:17:25 PM UTCavdykStatusInvalid=>Fixed
  Open/ClosedOpen=>Closed
Tue 06 Apr 2004 06:20:38 AM UTCavdykStatusFixed=>Invalid
  Open/ClosedClosed=>Open
Sat 06 Mar 2004 09:18:16 PM UTCavdykStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Sat 06 Mar 2004 07:48:14 PM UTCavdykSeverity3 - Normal=>4 - Important
  Assigned toNone=>avdyk

Back to the top


Powered by Savane 3.1-cleanup1