bugGNU GRUB - Bugs: bug #763, serial input escape sequence...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #763: serial input escape sequence recognition issues

Submitted by:  Ilguiz Latypov <ilgiz>
Submitted on:  Thu 27 Jun 2002 05:14:03 AM UTC  
 
Category: TerminalSeverity: Ordinary
Priority: 3 - LowItem Group: Action Request
Status: FixedPrivacy: Public
Assigned to: Yoshinori K. Okuji <okuji>Originator Name: 
Open/Closed: ClosedRelease: 2002-06-26
Release: NoneReproducibility: Intermittent
Planned Release: None

(Jump to the original submission Jump to the original submission)

Wed 03 Jul 2002 06:49:24 PM UTC, comment #6:

Fine to me!

Ilguiz Latypov <ilgiz>
Wed 03 Jul 2002 06:46:54 PM UTC, comment #5:

Thanks for your explanation. I mistook currticks for
getrtsecs.

As for delays for non-"escape sequences", they should be
negligible, as they are at most some ten milliseconds.
In reality, you shouldn't even notice the extra delays.

BTW, would you mind closing this report? If all the problem
has gone, I'd like to close it.

Okuji

Yoshinori K. Okuji <okuji>
Project AdministratorIn charge of this item.
Wed 03 Jul 2002 06:09:18 PM UTC, comment #4:

Everything is OK now on a Geode board at 115200 bps and 9600 bps.

To clear the suspicions against the original timer based implementation, the currticks() readings have resolution of 1/18 sec, so the escape sequence wait period was 1/9 sec.

The patch didn't refresh the wait timer once a part of valid escape sequence was received. On the positive side, it didn't wait at all when any other sequence such as single alphanumeric character was received.

Ilguiz Latypov <ilgiz>
Tue 02 Jul 2002 11:44:25 PM UTC, comment #3:

I've modified the logic a bit. Could you try?

BTW, the reason why I don't want to incorporate your patch
is not because of the size. Rather, I didn't like the
previous implementation, because it waited for at most
two seconds. That was really irritating. So I'm attempting
to add a delay, as short as possible.

Okuji

Yoshinori K. Okuji <okuji>
Project AdministratorIn charge of this item.
Tue 02 Jul 2002 04:38:58 PM UTC, comment #2:

All my difficulties were due to my own attempt to restore the wait escape sequence policy which existed before terminal code streamlining.

However, when I reverted my patch I found that after holding an arrow key in the command line for few seconds I was brought into the boot entry selection menu. I think that could be due to the wait loop being too fast. Will the 115200 bps rate produce intervals of hundreds microseconds? And what if I use a slower bit rate?

On reapplying my patch the problem has gone. The patch may not be efficient in terms of amount of code. It adds 96 bytes to stage2.

Ilguiz Latypov <ilgiz>
Sat 29 Jun 2002 08:57:30 PM UTC, comment #1:

Could you tell me what difficulty you have?
I thought the delay would be at most some microseconds,
even on an old 386 box.

Thanks,
Okuji

Yoshinori K. Okuji <okuji>
Project AdministratorIn charge of this item.
Thu 27 Jun 2002 05:14:03 AM UTC, original submission:

a) The serial input escape sequence recognition delay depends
on CPU speed.

b) The sequence translation is not invoked on each character read.
This means the eascape recognition delay will slow down alphanumeric
input.

A patch that restores the original behavior of the serial input
mechanism is attached.

Ilguiz Latypov <ilgiz>

 

Attached Files
file #44:  grub-serial-escape.diff added by ilgiz (3KiB - application/octet-stream - a patch for better (former) serial input escape sequence recognition)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 7 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 03 Jul 2002 07:25:15 PM UTCokujiStatusNone=>(Error - Not Found)
  Open/ClosedOpen=>(Error - Not Found)
  Closed on-=>-
Thu 27 Jun 2002 09:50:43 AM UTCokujiSeverityMajor=>(Error - Not Found)
  Priority100(Error - Not Found)=>(Error - Not Found)
  Assigned toNone=>NA
  Planned Release=>

Back to the top


Powered by Savane 3.1-cleanup1