bugGNU Octave - Bugs: bug #66895, (signal) make dist fails

 
 

bug #66895: (signal) make dist fails

Submitter:  Dmitri A. Sergatskov <dasergatskov>
Submitted:  Wed 12 Mar 2025 08:54:32 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * dev Release: 
Operating System:  * Mac OS Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 16 Mar 2025 11:42:34 PM UTC, comment #2: 

I thought that those are equivalent wrt external environment vars. The difference is the one is recursive and another is not, but it does make some difference here. But I also noticed:


HG_ID        := $(shell $(call HG_CMD,identify) --id | sed -e 's/+//' )


So with all those changes:

% hg diff
diff -r e1435f469762 Makefile
--- a/Makefile  Sat Feb 22 11:39:13 2025 -0500
+++ b/Makefile  Sun Mar 16 19:28:14 2025 -0400
@@ -11,9 +11,9 @@

 MKOCTFILE ?= mkoctfile
 OCTAVE    ?= octave
-SED       := sed
+SED       ?= sed
 SHA256SUM := sha256sum
-TAR       := tar
+TAR       ?= tar
 MAKEINFO  ?= makeinfo
 MAKEINFO_HTML_OPTIONS := --no-headers --set-customization-variable 'COPIABLE_LINKS 0' --set-customization-variable 'COPIABLE_ANCHORS 0' --no-split

@@ -42,7 +42,7 @@

 HG           := hg
 HG_CMD        = $(HG) --config alias.$(1)=$(1) --config defaults.$(1)= $(1)
-HG_ID        := $(shell $(call HG_CMD,identify) --id | sed -e 's/+//' )
+HG_ID        := $(shell $(call HG_CMD,identify) --id | $(SED) -e 's/+//' )
 HG_TIMESTAMP := $(firstword $(shell $(call HG_CMD,log) --rev $(HG_ID) --template '{date|hgdate}'))

 TAR_REPRODUCIBLE_OPTIONS := --sort=name --mtime="@$(HG_TIMESTAMP)" --owner=0 --group=0 --numeric-owner


I see now:

% TAR=gtar SED=gsed gmake dist V=1
Creating package version 1.4.6 release ...
rm -rf signal-1.4.6
hg --config alias.archive=archive --config defaults.archive= archive --exclude ".hg*" --type files --rev e1435f469762 signal-1.4.6
gmake BASEDIR=/Users/dmitri/src/octave-signal -C signal-1.4.6 build-docs
gmake[1]: Entering directory '/Users/dmitri/src/octave-signal/signal-1.4.6'
gmake[1]: *** No rule to make target 'doc/.texi', needed by 'doc/.qhc'.  Stop.
gmake[1]: Leaving directory '/Users/dmitri/src/octave-signal/signal-1.4.6'
gmake: *** [Makefile:79: signal-1.4.6] Error 2

% make clean
rm -f -f doc/.html
rm -f -f doc/.qhc
rm -f -f doc/.qch
rm -f -f doc/.info
rm -f -f doc/functions.texi
rm -f -f doc/version.texi
rm -rf - -.tar.gz -html.tar.gz -html
cd src && /Applications/Xcode.app/Contents/Developer/usr/bin/make clean
rm -f *.o *.oct PKG_*

% TAR=gtar SED=gsed gmake dist V=1
gtar -cf - --format=ustar --sort=name --mtime="@1740242353" --owner=0 --group=0 --numeric-owner signal-1.4.6 | gzip -9n > signal-1.4.6.tar.gz
rm -rf signal-1.4.6

% gls -Gg signal-1.4.6.tar.gz
-rw-r--r-- 1 263848 Mar 16 19:30 signal-1.4.6.tar.gz


And it installs fine.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Sun 16 Mar 2025 11:03:46 PM UTC, comment #1: 

The issue i guess is with:


PACKAGE := $(shell $(SED) -n -e 's/^Name: *\(\w\+\)/\1/p' DESCRIPTION)
VERSION := $(shell $(SED) -n -e 's/^Version: *\(\w\+\)/\1/p' DESCRIPTION)

But perhaps from:

SED       := sed
TAR       := tar

This would ignore your override  env settings ?

Perhaps:

SED       ?= sed
TAR       ?= tar


John Donoghue <lostbard>
Group Member
Wed 12 Mar 2025 08:54:32 AM UTC, original submission:  

Running on MacOS / Homebrew in signal hg id (e1435f469762 tip @)

% TAR=gtar SED=gsed gmake dist V=1
Creating package version  release ...
rm -rf -
hg --config alias.archive=archive --config defaults.archive= archive --exclude ".hg*" --type files --rev e1435f469762 -
abort: cannot archive plain files to stdout
gmake: *** [Makefile:78: -] Error 255
% hg --version
Mercurial Distributed SCM (version 6.9.3)

The shell is zsh. I tried from bash with the same result (but may be I did not do it proper -- I just run "bash" rather than "chsh" etc...).

Dmitri.
--


Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.14-7003.
    Corresponding source code