bugGNU Octave - Bugs: bug #66760, dsearch is not using tri

 
 

bug #66760: dsearch is not using tri

Submitter:  None
Submitted:  Fri 07 Feb 2025 06:13:36 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Patch Submitted Assigned to:  None
Originator Name:  Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 9.3.0
Operating System:  * Any Fixed Release:  10.1.0
Planned Release:  10.1.0
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Jump to the original submission

Mon 10 Feb 2025 10:27:58 PM UTC, comment #6: 

great, thanks.  i'll make a separate wishlist item for implementing tri.

Nicholas Jankowski <nrjank>
Group Member
Mon 10 Feb 2025 09:44:19 PM UTC, comment #5: 

This looks good.  I applied the patch to the stable branch.

Marking as Fixed and closing report.

Rik <rik5>
Group administrator
Mon 10 Feb 2025 03:03:25 AM UTC, comment #4: 

patch attached that updates the docstrings for dsearch and dsearchn. it also switches griddata to using dsearchn so that if we do deprecate and remove it griddate won't need to be changed later.

not sure what the status is of your 10.1 release.  whether or not we deprecate, ok to push this?  

I'll try to write up something on the projects page for updating the compiled `__dsearchn__` to actually use tri for efficiency purposes.

Nicholas Jankowski <nrjank>
Group Member
Fri 07 Feb 2025 11:41:03 PM UTC, comment #3: 
Rik <rik5>
Group administrator
Fri 07 Feb 2025 10:59:13 PM UTC, comment #2: 

dsearch is just a wrapper for dsearchn likely to not lose compatibility with old code, and both of them are just wrappers to the compiled _dsearchn_

since the calling form is fairly simple... i'm acutally kindof surprised it's not including tri.  note it also doesn't actually use S.  Both are just supposed to speed up efficiency by reusing an already computed result. so it supplying TRI shouldn't ever change the results.

I might play with this a bit to see if it's as simple as I'm imagining.

Nicholas Jankowski <nrjank>
Group Member
Fri 07 Feb 2025 10:34:47 PM UTC, comment #1: 

dsearch() was removed from Matlab in R2012A (13 years ago).  Wouldn't it make more sense just to remove the function?

Rik <rik5>
Group administrator
Fri 07 Feb 2025 06:13:36 PM UTC, original submission:  

Dsearch is not using the tri input argument. Thus should be noted in help dsearch. Thank you.

Anonymous

 

Attached Files

Attached Files
file #56872:  dsearch_bug77670.patch added by nrjank (2.4KiB - application/octet-stream)

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

    History

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2025-02-10 rik5 Fixed ReleaseNone 10.1.0
        Planned ReleaseNone 10.1.0
    2025-02-10 rik5 Open/ClosedOpen Closed
    2025-02-10 nrjank StatusNeed Info Patch Submitted
    2025-02-10 nrjank Attached File- Added dsearch_bug77670.patch, #56872
    2025-02-07 rik5 StatusNone Need Info
        Operating SystemMicrosoft Windows Any
    2025-02-07 rik5 Item GroupNone Documentation
    2025-02-07 rik5 CategoryNone Octave Function

    Back to the top

    Powered by Savane 3.16-a7ba.
    Corresponding source code