bugGNU Octave - Bugs: bug #66314, legend : wrong facealpha for patch...

 
 

bug #66314: legend : wrong facealpha for patch icons

Submitter:  Pantxo Diribarne <pantxo>
Submitted:  Thu 10 Oct 2024 02:18:01 PM UTC
   
 
Category:  Plotting with OpenGL Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 9.2.0 Operating System:  * Any
Fixed Release:  9.3.0 Planned Release:  9.3.0
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Jump to the original submission

Wed 16 Oct 2024 09:40:18 PM UTC, comment #6: 

Verified patch.  Marking as Fixed and closing report.

Rik <rik5>
Group administrator
Mon 14 Oct 2024 05:55:05 AM UTC, comment #5: 

Thanks for taking care of the tests. The reason why Gnuplot legends don't pass the test is because they are built with an old code that has not been updated for years.

Pantxo Diribarne <pantxo>
Group Member
Sun 13 Oct 2024 02:15:59 PM UTC, comment #4: 

I pushed a follow-up to simplify the test:
https://hg.savann ... /rev/a34c6cae87ea

It is currently failing for the graphics toolkit "gnuplot". (The "facealpha" property of the patch in the legend is 1.) I don't know why it is failing though.
The graphics toolkit "gnuplot" is no longer actively maintained. So, I just skipped the test in case it is used. If someone would like to fix it, that condition can be removed again.

Markus Mützel <mmuetzel>
Group administrator
Fri 11 Oct 2024 07:14:48 PM UTC, comment #3: 

tests pass. pushed as

http://hg.savanna ... /rev/f6dc87a62819

marking as ready for test.

Nicholas Jankowski <nrjank>
Group Member
Thu 10 Oct 2024 09:00:47 PM UTC, comment #2: 

thanks for the quick patch. added a small BIST to verify the icon patch did inherit the property and added a note to news.  rebuilding/testing stable and default after the change and can push it once those pass.

Nicholas Jankowski <nrjank>
Group Member
Thu 10 Oct 2024 06:28:34 PM UTC, comment #1: 

Here is the patch.

(file #56495)

Pantxo Diribarne <pantxo>
Group Member
Thu 10 Oct 2024 02:18:01 PM UTC, original submission:  

Legend icons for patch objects don't copy the original facealpha property. E.g.


hp = patch ();
set (hp, 'facealpha', 0.5)
legend ('Should be transparent')


I'll come with a simple patch.

Pantxo Diribarne <pantxo>
Group Member

 

Attached Files

Attached Files
file #56495:  bug66314.patch added by pantxo (1.3KiB - text/x-patch)

(Note: upload size limit is set to 16MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by pantxo (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    History

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-10-16 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone 9.3.0
    2024-10-11 nrjank StatusPatch Reviewed Ready For Test
    2024-10-10 nrjank Planned ReleaseNone 9.3.0
    2024-10-10 nrjank StatusPatch Submitted Patch Reviewed
    2024-10-10 pantxo Attached File- Added bug66314.patch, #56495
        StatusConfirmed Patch Submitted

    Back to the top

    Powered by Savane 3.16.
    Corresponding source code