bugGNU GRUB - Bugs: bug #66300, grub-mkconfig: Missing support for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #66300: grub-mkconfig: Missing support for partition labels

Submitter:  David C. Manuelda <stormbyte>
Submitted:  Mon 07 Oct 2024 03:54:01 PM UTC
   
 
Category:  Configuration Severity:  Major
Priority:  5 - Normal Item Group:  Feature Request
Status:  None Privacy:  Public
Assigned to:  None Originator Name:  David C. Manuelda
Open/Closed:  Open Release:  Git master
Release:  Reproducibility:  Every Time
Planned Release:  None

Tue 08 Oct 2024 01:06:53 PM UTC, comment #3: 

As posted in the development mailing list I've updated a typo that was preventing the feature from working correctly, I apologize.

(file #56490)

David C. Manuelda <stormbyte>
Tue 08 Oct 2024 11:34:18 AM UTC, comment #2: 

Sorry, forgot to commit the code portion relative to GRUB_DISABLE_LINUX_LABEL variable default value.

Attaching the definitive and final patch.

(file #56487)

David C. Manuelda <stormbyte>
Tue 08 Oct 2024 11:26:00 AM UTC, comment #1: 

To maintain grub codestyle and current functionality flow I updated the patch so now the feature will only be applied if UUIDs and PARTUUIDs are disabled (with GRUB_DISABLE_LINUX_UUID=true and GRUB_DISABLE_LINUX_PARTUUID=true) and the new user variable introduced to control this feature has been renamed to GRUB_DISABLE_LINUX_UUID.

Please drop the previous patch in favor of this one.

(file #56486)

David C. Manuelda <stormbyte>
Mon 07 Oct 2024 03:54:01 PM UTC, original submission:  

When using grub-mkconfig, UUIDs and PARTUUIDs can be used or excluded depending on GRUB_DISABLE_LINUX_UUID and GRUB_DISABLE_LINUX_PARTUUID respectively but there is nothing about using labels to identify the Linux root filesystem.

I am attaching a patch which kindly introduces a new variable GRUB_PREFER_LINUX_LABEL which if set to true will use the partition label instead if available (if not, the functionality will remain the same).

It can be improved because I don't quite like having nearly the same command twice but for proof of concept I think it should be enough (also to help users wanting this feature to have it early)

Can something like this have a chance?

David C. Manuelda <stormbyte>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #56490:  0001-Introduce-grub-mkconfig-filesystem-label-support.patch added by stormbyte (5KiB - text/x-patch - Corrected a typo preventing the feature from working correctly)
file #56487:  0001-Introduce-grub-mkconfig-filesystem-label-support.patch added by stormbyte (5KiB - text/x-patch - Final version for the patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by stormbyte (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-10-08 stormbyte Attached File- Added 0001-Introduce-grub-mkconfig-filesystem-label-support.patch, #56490
    2024-10-08 stormbyte Attached File- Added 0001-Introduce-grub-mkconfig-filesystem-label-support.patch, #56487
    2024-10-08 stormbyte Attached File- Added 0001-Introduce-grub-mkconfig-filesystem-label-support.patch, #56486
    2024-10-07 stormbyte Attached File- Added 0001-Introducing-new-GRUB_PREFER_LINUX_LABEL-variable-whi.patch, #56483

    Back to the top

    Powered by Savane 3.15-e6e5.
    Corresponding source code