bugGNU Octave - Bugs: bug #65873, uitable dropdowns not editable...

 
 

bug #65873: uitable dropdowns not editable with Qt6

Submitter:  mspo
Submitted:  Tue 11 Jun 2024 01:52:00 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 9.2.0 Operating System:  * Any
Fixed Release:  9.3.0 Planned Release:  9.3.0
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Jump to the original submission

Mon 17 Jun 2024 08:10:26 AM UTC, comment #7: 

You beat me to it. The nightly version fixes it on my system as well. Thank you!

mspo
Sun 16 Jun 2024 09:58:43 AM UTC, comment #6: 

I downloaded the nightly build (Sat, Jun 15, 2024) from nightly.octave.org.
With that version, using the dropdown lists in the uitable from comment #0 correctly updates the "data" property. Also, the "celleditcallback" is being executed again.

Closing report as fixed.

Markus Mützel <mmuetzel>
Group administrator
Wed 12 Jun 2024 09:03:07 AM UTC, comment #5: 

Thank you for the review.

I pushed the patch to the stable branch:
https://hg.savann ... /rev/b44cf0267b59

It should be part of the next bug fix release (Octave 9.3.0).

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Tue 11 Jun 2024 08:46:10 PM UTC, comment #4: 

Looks good to me.

Torsten Lilge <ttl>
Group Member
Tue 11 Jun 2024 05:33:53 PM UTC, comment #3: 

Doesn't seem to break with Qt5.

@Torsten: I'm not an expert in using Qt. Does that change look reasonable?

Markus Mützel <mmuetzel>
Group administrator
Tue 11 Jun 2024 04:58:27 PM UTC, comment #2: 

The attached patch fixes it for me with Qt6. Currently untested with Qt5.


(file #56155)

Markus Mützel <mmuetzel>
Group administrator
Tue 11 Jun 2024 02:46:02 PM UTC, comment #1: 

I can confirm that the "data" property of the uitable doesn't change when interacting with the dropdown boxes if Octave is built with Qt6. Also, the 'celleditcallback' is no longer being executed. That is the same on Windows and on Ubuntu 24.04.
It is still working fine if Octave is built with Qt5 (on Windows and on Ubuntu).

The respective code is probably in "libgui/graphics/Table.cc", maybe the function "comboBoxCurrentIndexChanged" in that file or one of the related signals or events.

Might also be an issue with Qt6 itself?

Markus Mützel <mmuetzel>
Group administrator
Tue 11 Jun 2024 01:52:00 PM UTC, original submission:  

I just noticed with the latest Octave version that editing dropdown cells in uitables stopped working with Octave 9.2.0. The celleditcallback is not called for this cell type. Other cell types are fine - although I didn't test all of them. It still worked with Octave 9.1.0. I work with Windows 10 22H2.

Here is a reproducible example (Try changing a numeric cell and a dropdown):


uitable('data', [{1;2}, {'B'; 'A'}], 'columnformat', {'numeric', {'A'; 'B'}}, 'columneditable', true, 'cellselectioncallback', @(obj, event) myselection(obj, event), 'celleditcallback', @(obj, event) myedit(obj, event));

function myselection(obj, event)
  disp('cell selected: ')
  disp(event)
end

function myedit(obj, event)
  disp('cell edited: ')
  disp(event)
end


mspo

 

Attached Files

Attached Files
file #56155:  bug65873-uitable-combo-box-update.patch added by mmuetzel (1.1KiB - application/octet-stream)

(Note: upload size limit is set to 16MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by mspo (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    History

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-06-16 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone 9.3.0
    2024-06-12 mmuetzel StatusPatch Submitted Ready For Test
        Summaryuitable dropdowns not editable anymore uitable dropdowns not editable with Qt6
    2024-06-11 mmuetzel Carbon-Copy- Added ttl
    2024-06-11 mmuetzel Attached File- Added bug65873-uitable-combo-box-update.patch, #56155
        StatusConfirmed Patch Submitted
        Planned ReleaseNone 9.3.0
    2024-06-11 mmuetzel CategoryOctave Function GUI
        Item GroupNone Regression
        StatusNone Confirmed
        Operating SystemMicrosoft Windows Any

    Back to the top

    Powered by Savane 3.16.
    Corresponding source code