bugGNU Octave - Bugs: bug #65476, mkoctfile -p LIBS now includes...

 
 

bug #65476: mkoctfile -p LIBS now includes many dependencies

Submitter:  Orion Poplawski <opoplawski>
Submitted:  Sun 17 Mar 2024 06:14:13 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Confirmed Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * 9.1.0 Operating System:  * Any
Fixed Release:  None Planned Release:  9.2.0 (current stable)
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 18 Mar 2024 08:09:04 AM UTC, comment #2: 

Likely a regression from this change:
https://hg.savannah.gnu.org/hgweb/octave/rev/baf7621aa073

I nested a new m4 macro inside those configure checks that also uses `save_LIBS` to save and restore the value of the `LIBS` variable. Thus, the outer `save_LIBS` is overridden and the original value is no longer restored correctly.
A similar issue likely happens for the other variables that are potentially set in restored in those m4 macros.

I'll try to propose a patch some time later today.

Markus Mützel <mmuetzel>
Group administrator
Mon 18 Mar 2024 07:58:41 AM UTC, comment #1: 

Thank you for the report. That doesn't look correct indeed.

I can confirm the issue on Windows.

It looks like the `LIBS` variable doesn't get correctly reset to its previous value after the tests for the SUNDIALS libraries around here:
https://hg.savannah.gnu.org/hgweb/octave/file/5aa35bb9063c/configure.ac#l2302

I don't see immediately why that is happening...

(I added a "9.1.0" value for the "Release" field and changed it for this report.)

Markus Mützel <mmuetzel>
Group administrator
Sun 17 Mar 2024 06:14:13 PM UTC, original submission:  

With the change from octave 8.4.0 to 9.1.0 in the Fedora package, mkoctfile -p LIBS goes from:

-lpthread -lm

to

-lsundials_ida -lsundials_nvecserial -lklu -lflexiblas  -L/usr/lib/gcc/x86_64-redhat-linux/14 -L/usr/lib/gcc/x86_64-redhat-linux/14/../../../../lib64 -L/lib/../lib64 -L/usr/lib/../lib64 -L/usr/lib/gcc/x86_64-redhat-linux/14/../../.. -lgfortran -lm -lquadmath -lpthread -lm

Is that expected? Generally listing all of the dependent libs is only needed with static linking.

(BTW - no 9.1.0 release yet in the dropdown)

Orion Poplawski <opoplawski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by opoplawski (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    08:01 mmuetzel Planned Release9.1.0 9.2.0 (current stable)
    07:58 mmuetzel StatusNone Confirmed
        Release9.0.90 9.1.0
        Operating SystemGNU/Linux Any
        Planned ReleaseNone 9.1.0

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code