bugGNU Octave - Bugs: bug #65476, mkoctfile -p LIBS now includes...

 
 

bug #65476: mkoctfile -p LIBS now includes many dependencies

Submitter:  Orion Poplawski <opoplawski>
Submitted:  Sun 17 Mar 2024 06:14:13 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 9.1.0 Operating System:  * Any
Fixed Release:  None Planned Release:  9.2.0
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Wed 20 Mar 2024 07:15:50 AM UTC, comment #5: 

Thanks for testing.
I wanted to wait to get confirmation from at least one other system than mine. Now there are two: You and Philip in bug #65460. 😊

I pushed the change to the stable branch:
https://hg.savann ... /rev/557fbfea93ab

This error might warrant a soonish bug fix release for Octave 9...

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Tue 19 Mar 2024 11:42:32 PM UTC, comment #4: 

Patch works for me.  I would go ahead and push it.

Rik <rik5>
Group administrator
Mon 18 Mar 2024 02:21:53 PM UTC, comment #3: 

The attached patch fixes this issue for me.


(file #55859)

Markus Mützel <mmuetzel>
Group administrator
Mon 18 Mar 2024 08:09:04 AM UTC, comment #2: 

Likely a regression from this change:
https://hg.savann ... /rev/baf7621aa073

I nested a new m4 macro inside those configure checks that also uses `save_LIBS` to save and restore the value of the `LIBS` variable. Thus, the outer `save_LIBS` is overridden and the original value is no longer restored correctly.
A similar issue likely happens for the other variables that are potentially set in restored in those m4 macros.

I'll try to propose a patch some time later today.

Markus Mützel <mmuetzel>
Group administrator
Mon 18 Mar 2024 07:58:41 AM UTC, comment #1: 

Thank you for the report. That doesn't look correct indeed.

I can confirm the issue on Windows.

It looks like the `LIBS` variable doesn't get correctly reset to its previous value after the tests for the SUNDIALS libraries around here:
https://hg.savann ... onfigure.ac#l2302

I don't see immediately why that is happening...

(I added a "9.1.0" value for the "Release" field and changed it for this report.)

Markus Mützel <mmuetzel>
Group administrator
Sun 17 Mar 2024 06:14:13 PM UTC, original submission:  

With the change from octave 8.4.0 to 9.1.0 in the Fedora package, mkoctfile -p LIBS goes from:

-lpthread -lm

to

-lsundials_ida -lsundials_nvecserial -lklu -lflexiblas  -L/usr/lib/gcc/x86_64-redhat-linux/14 -L/usr/lib/gcc/x86_64-redhat-linux/14/../../../../lib64 -L/lib/../lib64 -L/usr/lib/../lib64 -L/usr/lib/gcc/x86_64-redhat-linux/14/../../.. -lgfortran -lm -lquadmath -lpthread -lm

Is that expected? Generally listing all of the dependent libs is only needed with static linking.

(BTW - no 9.1.0 release yet in the dropdown)

Orion Poplawski <opoplawski>

 

Attached Files

Attached Files

(Note: upload size limit is set to 16MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

Digest:
   bug dependencies.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by opoplawski (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    History

    Follow 12 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-03-22 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2024-03-20 mmuetzel StatusPatch Reviewed Ready For Test
    2024-03-20 mmuetzel Dependencies- bugs #65460 is dependent
    2024-03-19 rik5 StatusPatch Submitted Patch Reviewed
    2024-03-18 mmuetzel Attached File- Added bug65476-build-sundials-save.patch, #55859
        StatusConfirmed Patch Submitted
    2024-03-18 mmuetzel Planned Release9.1.0 9.2.0
    2024-03-18 mmuetzel StatusNone Confirmed
        Release9.0.90 9.1.0
        Operating SystemGNU/Linux Any
        Planned ReleaseNone 9.1.0

    Back to the top

    Powered by Savane 3.16.
    Corresponding source code