bugGNU roff - Bugs: bug #64959, [troff] add unit tests for...

 
 

bug #64959: [troff] add unit tests for `device` and `output` requests

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Fri 01 Dec 2023 09:13:13 PM UTC
   
 
Category:  Core Severity:  1 - Wish
Item Group:  Test Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.24.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 11 Jan 2024 05:00:57 AM UTC, comment #3: 


commit 76b48901e8815939636edb91040c4ff2ac2bca1a
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Jan 8 19:31:59 2024 -0600

    [troff]: Add unit test for `device` request.

    * src/roff/groff/tests/device-request-works.sh: Add test.
    * src/roff/groff/groff.am (groff_TESTS): Run test.

    Fixes <https://savannah.gnu.org/bugs/?64959>.

commit 587316f3b4beaae9f56458b5026abcad6a5299c0
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Jan 8 06:39:28 2024 -0600

    [troff]: Add tests of "early" formatter features.

    [troff]: Add tests of early usage of formatter features that throw fatal
    errors when called "too early", but for which this error handling
    appears to be dead code.  Further test the `output` request in
    furtherance of Savannah #64959.

    * src/roff/groff/tests/backslash-exclamation-early-does-not-fail.sh:
    * src/roff/groff/tests/cf-request-early-does-not-fail.sh:
    * src/roff/groff/tests/output-request-works.sh: Add tests.

    * src/roff/groff/groff.am (groff_TESTS): Run tests.


G. Branden Robinson <gbranden>
Group administrator
Tue 09 Jan 2024 01:56:02 AM UTC, comment #2: 

comment #1:

> Being dealt with in bug #65118.


Nope.  Bug #65138.

G. Branden Robinson <gbranden>
Group administrator
Tue 09 Jan 2024 01:54:44 AM UTC, comment #1: 


original submission:

> There appears to be an undiagnosed issue with `device`.  You can invoke it "too early", and it won't appear on the output.  This might be the case any time the vertical drawing position is negative.  Investigate and document.


Being dealt with in bug #65118.
 

> You can invoke `output` wherever you want, but this can also break the invariant claimed in "Document parts" [sic] of groff_out(5).  So something documentary needs to be said about that too.


I think I was mistaken here.  While developing unit tests, I can't actually get anything to appear ahead of the "grout leader" ("x T ps" and so forth).

The rest is in progress.

G. Branden Robinson <gbranden>
Group administrator
Fri 01 Dec 2023 09:13:13 PM UTC, original submission:  

Check a few cases:

1. plain usage
2. leading quotation mark for passage of multi-word argument(s)
3. usage very early in the document

There appears to be an undiagnosed issue with `device`.  You can invoke it "too early", and it won't appear on the output.  This might be the case any time the vertical drawing position is negative.  Investigate and document.

You can invoke `output` wherever you want, but this can also break the invariant claimed in "Document parts" [sic] of groff_out(5).  So something documentary needs to be said about that too.

G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-01-11 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.24.0
    2024-01-09 gbranden StatusNone In Progress
        Assigned toNone gbranden

    Back to the top

    Powered by Savane 3.13-04b1.
    Corresponding source code