bugGNU Octave - Bugs: bug #64853, Misc bytecode interpreter fixes

 
 

bug #64853: Misc bytecode interpreter fixes

Submitter:  Petter <petter>
Submitted:  Sat 04 Nov 2023 12:41:52 AM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 04 Nov 2023 01:46:49 PM UTC, comment #1: 

Edited some summaries and pushed to default after testing. Ready for test.

Arun Giridhar <arungiridhar>
Group Member
Sat 04 Nov 2023 12:41:52 AM UTC, original submission:  

32551:

Change some printf to cout

According to coding guidelines. Some printf:es are left
till std::format C17++ can be used.

* pt-bytecode-vm.cc: printf -> cout

32552:

Set uninitialized m_ip field

The field was not set during some circumstances
which could potentially give the wrong line number in
warnings and errors from the bytecode interpreter.

* stack-frame.cc: Default init to 0.

32553:

Do type check before static_cast to wrong type

The virtual function is_defined() was called on a pointer to octave_cached_value
, when the object actually was a octave_base_value. The type check call need to
be done on a pointer to the base class to be standard compliant.

* pt-bytecode-vm.cc: Comply

32554:

Replace public field with getter setter

Follow coding guidelines for m_compilation_failed.

* ov-usr_fcn.h: Def getter setter, hide field
* pt-bytecode-vm.cc: Use getter setter
* ov-fcn-handle.cc: Use setter


Petter <petter>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55301:  octave_32551.patch added by petter (10KiB - text/plain)
file #55302:  octave_32553.patch added by petter (2KiB - text/plain)
file #55303:  octave_32552.patch added by petter (911B - text/plain)
file #55304:  octave_32554.patch added by petter (2KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Posted a comment)
  • -email is unavailable- added by petter (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-12-23 arungiridhar StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2023-11-04 arungiridhar StatusNone Ready For Test
    2023-11-04 petter Attached File- Added octave_32551.patch, #55301
        Attached File- Added octave_32553.patch, #55302
        Attached File- Added octave_32552.patch, #55303
        Attached File- Added octave_32554.patch, #55304

    Back to the top

    Powered by Savane 3.13-0159.
    Corresponding source code