bugGNU Octave - Bugs: bug #64580, qt 5.7.1 fails to build: missing...

 
 

bug #64580: qt 5.7.1 fails to build: missing QSqlDatabase header

Submitter:  A.R. Burgers <arb>
Submitted:  Tue 22 Aug 2023 01:18:36 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  9.1.0 (current stable) Planned Release:  9.1.0 (current stable)
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 28 Aug 2023 10:01:56 AM UTC, comment #12: 

Thank you for checking and reporting back.

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Mon 28 Aug 2023 09:38:15 AM UTC, comment #11: 

yes, builds cleanly again.

A.R. Burgers <arb>
Sat 26 Aug 2023 04:26:57 PM UTC, comment #10: 

I have pushed the patch which removes the dependency with cset http://hg.savannah.gnu.org/hgweb/octave/rev/3de9f020ce41

Torsten Lilge <ttl>
Group Member
Sat 26 Aug 2023 10:13:15 AM UTC, comment #9: 

Imho, a "Maybe, the Qt SQLite module is missing." that is always added to the warning (like you proposed) might still be good enough™.
But you understand the possible struggles better. So, whatever you decide is good for me. 🙂

Markus Mützel <mmuetzel>
Group administrator
Sat 26 Aug 2023 10:05:43 AM UTC, comment #8: 

Without the dependency we have the same error message as before, just saying that the docs are not available as it was not possible to setup the required data. If we remove the new test we could add the hint "Maybe the Qt SQlite module is missing" to the existing message.

Torsten Lilge <ttl>
Group Member
Sat 26 Aug 2023 07:01:07 AM UTC, comment #7: 


comment #5:

> We can also remove the use of this include as it was necessary for an additional test (and more accurate error message) before setting up the qhelp data.


Can the error message still be reasonable specific without that new dependency? I agree that it might be "over the top" to add that new dependency if the advantage from it is only minor.

Markus Mützel <mmuetzel>
Group administrator
Wed 23 Aug 2023 09:11:47 PM UTC, comment #6: 

Qt 5.7.1 was installed from a pre-compiled installer from the Qt web site. But I did (have to) install Qscintilla from source, maybe qsql is an external package as well, at least for 5.7.1

A.R. Burgers <arb>
Wed 23 Aug 2023 06:39:39 PM UTC, comment #5: 

We can also remove the use of this include as it was necessary for an additional test (and more accurate error message) before setting up the qhelp data.

Torsten Lilge <ttl>
Group Member
Wed 23 Aug 2023 04:58:04 PM UTC, comment #4: 

I didn't test at all yet. But does the attached patch help?


(file #55071)

Markus Mützel <mmuetzel>
Group administrator
Wed 23 Aug 2023 12:34:01 PM UTC, comment #3: 

Thats a maybe ... as I havent tried it, but we should probally be checking for the QtSql package in configure since we are using it

John Donoghue <lostbard>
Group Member
Wed 23 Aug 2023 12:30:55 PM UTC, comment #2: 

SqlDatabase was added as Qt6 fix in https://hg.savannah.gnu.org/hgweb/octave/rev/77ca9064ed4a

But QSqlDatabse comes from the QSql package which we are not pulling in the include paths as we do with the other Qt modules in acinclude.m4 OCTAVE_CHECK_QT_VERSION

John Donoghue <lostbard>
Group Member
Wed 23 Aug 2023 05:50:23 AM UTC, comment #1: 

That header should be around since Qt4 times. Do you have the necessary dev packages installed?
Could you please show the failing command if you run `make` with `V=1`?

Markus Mützel <mmuetzel>
Group administrator
Tue 22 Aug 2023 01:18:36 PM UTC, original submission:  

I am getting this build error with qt 5.7.1 in recent dev versions:


  CXX      libgui/src/libgui_src_libgui_src_la-documentation.lo
../octave/libgui/src/documentation.cc:51:10: fatal error: QSqlDatabase: No such file or directory
   51 | #include <QSqlDatabase>


A.R. Burgers <arb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55071:  bug64580-build-qt-sql.patch added by mmuetzel (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by arb (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-08-28 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone 9.1.0 (current stable)
        Planned ReleaseNone 9.1.0 (current stable)
        Summaryqt 5.7.1 fails to build: missing QSqlDatabase head qt 5.7.1 fails to build: missing QSqlDatabase header
    2023-08-26 ttl StatusPatch Submitted Ready For Test
    2023-08-23 mmuetzel Attached File- Added bug64580-build-qt-sql.patch, #55071
        StatusNeed Info Patch Submitted
        Operating SystemGNU/Linux Any
    2023-08-23 mmuetzel StatusNone Need Info

    Back to the top

    Powered by Savane 3.13-04b1.
    Corresponding source code