bugGNU Octave - Bugs: bug #64050, inputParser does not implement...

 
 

bug #64050: inputParser does not implement PartialMatching

Submitter:  Rik <rik5>
Submitted:  Sat 15 Apr 2023 02:52:51 PM UTC
   
 
Category:  Octave Function Severity:  1 - Wish
Priority:  5 - Normal Item Group:  Matlab Compatibility
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  9.1.0 (current stable) Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 26 Apr 2023 06:11:06 PM UTC, comment #7: 

It's been a week now.  Marking as Fixed and closing report.

Rik <rik5>
Group administrator
Thu 20 Apr 2023 02:34:26 PM UTC, comment #6: 

Updated inputParser again in this cset http://hg.savannah.gnu.org/hgweb/octave/rev/01868cd10060.  The buildbots now seem happy.

Rik <rik5>
Group administrator
Thu 20 Apr 2023 02:33:34 AM UTC, comment #5: 

looks like this was fixed with bug #64050. getting no test failures now.

Nicholas Jankowski <nrjank>
Group Member
Wed 19 Apr 2023 12:47:24 AM UTC, comment #4: 

There are few FAILures in odex functions.


  ode/ode15s.m ................................................... pass    1/40
                                                                   FAIL   39
  ode/ode23.m .................................................... pass   36/41
                                                                   FAIL    5
  ode/ode23s.m ................................................... pass   32/37
                                                                   FAIL    5
  ode/ode45.m .................................................... pass   10/44
                                                                   FAIL   34
  ode/odeget.m ................................................... pass   14/14
  ode/odeset.m ................................................... pass    6/9
                                                                   FAIL    3


E.g.:
https://buildbot.octave.org/#/builders/24/builds/365/steps/7/logs/stdio


octave:1> test ode15s
***** testif HAVE_SUNDIALS
 opt = odeset ("MStateDependence", "none",
               "Mass", [1, 0, 0; 0, 1, 0; 0, 0, 0]);
 [t, y] = ode15s (@rob, [0, 100], [1; 0; 0], opt);
 assert ([t(end), y(end,:)], frefrob, 1e-3);
!!!!! test failed
argument 'Mass' matches more than one Parameter: 'Mass', 'MassSingular'.
octave:2> test ode23
***** test  # Mass option as function
 opt = odeset ("Mass", @fmas);
 sol = ode23 (@fpol, [0 2], [2 0], opt);
 assert ([sol.x(end); sol.y(:,end)], [2; fref'], 1e-3);
!!!!! test failed
argument 'Mass' matches more than one Parameter: 'Mass', 'MassSingular'.


etc...

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Tue 18 Apr 2023 10:36:30 PM UTC, comment #3: 

Thanks, missed one "@end deftypefn".  Should be fixed now.  See http://hg.savannah.gnu.org/hgweb/octave/rev/c5c065221a0e.

Rik <rik5>
Group administrator
Tue 18 Apr 2023 09:06:44 PM UTC, comment #2: 

It appears that there are some problem with docs:

if /bin/sh /home/dima/src/dev/octave/build-aux/missing makeinfo   -I doc/interpreter -I /home/dima/src/dev/octave/clang_gopt/../doc/interpreter \
 -o ../doc/interpreter/octave.info ../doc/interpreter/octave.texi; \
then \
  rc=0; \
  CDPATH="${ZSH_VERSION+.}:" && cd ..; \
else \
  rc=$?; \
  CDPATH="${ZSH_VERSION+.}:" && cd .. && \
  $restore $backupdir/* `echo "./../doc/interpreter/octave.info" | sed 's|[^/]*$||'`; \
fi; \
rm -rf $backupdir; exit $rc
func.texi:1683: @node seen before @end deftypefn


Also e.g.:

https://buildbot.octave.org/#/builders/21/builds/367/steps/6/logs/stdio

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Tue 18 Apr 2023 08:49:20 PM UTC, comment #1: 

I implemented the functionality in this changeset http://hg.savannah.gnu.org/hgweb/octave/rev/80fef9315743.

Marking as Ready for Test.

Rik <rik5>
Group administrator
Sat 15 Apr 2023 02:52:51 PM UTC, original submission:  

PartialMatching is not implemented and throws an error if attempted.

Example code:


p = inputParser ();
p.PartialMatching = true
error: inputParser: PartialMatching is not yet implemented
error: called from
    set.PartialMatching at line 203 column 9


Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-04-26 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone 9.1.0 (current stable)
    2023-04-18 rik5 StatusConfirmed Ready For Test

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code