bugGNU Health - Bugs: bug #63687, Access rights for Imaging

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #63687: Access rights for Imaging

Submitter:  Mathias Behrle <yangoon>
Submitted:  Sun 22 Jan 2023 11:03:53 AM UTC
   
 
Category:  Functionality Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  meanmicio
Open/Closed:  Closed Release:  4.1.0
Module:  health_imaging Component:  Hospital Management

Jump to the original submission

Tue 24 Jan 2023 08:39:06 PM UTC, comment #6: 

Quick tip about menu entries...

The "MI" command line in the GH native GTK client takes you directly to the results, and allows you to pass arguments. Quite handy :)

Luis Falcon <meanmicio>
Group administrator
Tue 24 Jan 2023 08:24:19 PM UTC, comment #5: 

I think I see what you mean. The user assignment is there, I just placed in another section on the file:

https://hg.savannah.gnu.org/hgweb/health/file/70a208965e12/tryton/health_imaging/security/access_rights.xml#l69

About the menu and relate actions entries, I have remove the "-" from the medical imaging requests. Now they are the same in both contexts.

Having the whole name might look a bit reduntant from the menuentry, but it's important to have so it can recall it directly from the search area, and makes it easier for the translators to get the context.

Think we're pretty much ok at this point, so I'm closing this issue. Please feel free to open it if you find anything!

Bests
Luis

Luis Falcon <meanmicio>
Group administrator
Tue 24 Jan 2023 12:38:19 PM UTC, comment #4: 


comment #3:

> Great! Ready for testing...
>
> Please check the screenshot with updated terms on menuentries and relate actions
> https://i.imgur.com/34vve3y.png


Looks good, a few nitpicks:

For consistency I would choose one format for all entries. As can be seen on the screenshot also the Relate differs from the menu for the Results.

Inside the Medical Imaging menu I wouldn't prefix the items with the menu name, it is evident. On the relates I would put the version without dash.
 

> As far as the access rights, those entries that you mention are for the admin_group (and admin user). There are also the ones for the medical imaging team and doctors.


Yes, but there is an entry removed for the admin. I didn't have a closer look, but it looks like the admin could miss accidently some access rights.

Mathias Behrle <yangoon>
Tue 24 Jan 2023 11:39:06 AM UTC, comment #3: 

Great! Ready for testing...

Please check the screenshot with updated terms on menuentries and relate actions
https://i.imgur.com/34vve3y.png

As far as the access rights, those entries that you mention are for the admin_group (and admin user). There are also the ones for the medical imaging team and doctors.


changeset:   5672:61b602852d0a
summary:     bug #63687: Access rights for Imaging. Update Menuentries and fields with Medical Imaging and Studies

changeset:   5671:1d51f3d84276
summary:     bug #63687: Access rights for Imaging. Add access rights to group_health_imaging

Luis Falcon <meanmicio>
Group administrator
Tue 24 Jan 2023 08:45:19 AM UTC, comment #2: 

comment #1:

> original submission:
> > Group 'Health imaging' has menu access
> >
> > Health / Configuration / Dx Imaging
> > Health
>
> I like Dx Imaging, as per "Diagnostic Imaging".
> Although, I think it would be better and more consistent to use "Medical Imaging".
>
> We could replace menu and relate actions to "Medical Imaging". 
>
> What do you think?


Indeed I didn't have a notion about the meaning of Dx, so I am absolutely in favor to rename to 'Medical Imaging'.

S.a. https://en.wikipedia.org/wiki/Medical_imaging


> > Group 'Health imaging' has no read permissions any Imaging models
> >
> > should probably have read access for all.
> >
> Agree!
>
> We'll update the access_rights.xml file on health_imaging and populate group_health_imaging with some useful access rights.


I see on the changeset

-<!-- Assign the Group to the "admin" user -->
-
-        <record model="res.user-res.group" id="user_admin_group_health_imaging_admin">
-            <field name="user" ref="res.user_admin"/>
-            <field name="group" ref="group_health_imaging_admin"/>
-        </record>
 
which perhaps slipped in inadvertently?


Mathias Behrle <yangoon>
Mon 23 Jan 2023 06:41:18 PM UTC, comment #1: 

Hi, Mathias

Thanks for the feedback!

original submission:

> Group 'Health imaging' has menu access
>
> Health / Configuration / Dx Imaging
> Health


I like Dx Imaging, as per "Diagnostic Imaging".
Although, I think it would be better and more consistent to use "Medical Imaging".

We could replace menu and relate actions to "Medical Imaging". 

What do you think?

>
> Group 'Health imaging' has no read permissions any Imaging models
>
> should probably have read access for all.
>

Agree!

We'll update the access_rights.xml file on health_imaging and populate group_health_imaging with some useful access rights.


>
> On the same move
> 'Health imaging Administration' and 'Health imaging'
> could be corrected to
> 'Health Imaging Administration' and 'Health Imaging'


Indeed :)

I'll commit and update this issue.

Bests
Luis

Luis Falcon <meanmicio>
Group administrator
Sun 22 Jan 2023 11:03:53 AM UTC, original submission:  

Group 'Health imaging' has menu access

Health / Configuration / Dx Imaging
Health

should be

Health
Health /Imaging


Group 'Health imaging' has no read permissions any Imaging models

should probably have read access for all.


On the same move
'Health imaging Administration' and 'Health imaging'
could be corrected to
'Health Imaging Administration' and 'Health Imaging'

Mathias Behrle <yangoon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meanmicio (Posted a comment)
  • -email is unavailable- added by yangoon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-01-24 meanmicio StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2023-01-24 meanmicio StatusIn Progress Ready For Test
    2023-01-23 meanmicio StatusNone In Progress
        Assigned toNone meanmicio
        ReleaseNone 4.1.0
        ComponentNone Hospital Management

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code