bugGNU Health - Bugs: bug #63168, Skiptest attribute is not longer...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #63168: Skiptest attribute is not longer supported on upstream

Submitter:  Sergi Almacellas Abellana <pokoli>
Submitted:  Thu 06 Oct 2022 07:51:01 AM UTC
   
 
Category:  Tryton Severity:  2 - Minor
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  pokoli
Open/Closed:  Closed Release:  4.1.0
Module:  health Component:  Hospital Management

Thu 06 Oct 2022 11:21:08 AM UTC, comment #5: 
Sergi Almacellas Abellana <pokoli>
Thu 06 Oct 2022 09:51:20 AM UTC, comment #4: 

Excellent, Sergi!

I will create the task and link it to this issue, just for accountability.

Bests
Luis


Luis Falcon <meanmicio>
Group administrator
Thu 06 Oct 2022 09:31:27 AM UTC, comment #3: 

Thanks for the fast reply Luis!

Great, There is no need to open a task.
I will just fix it, push the changes for the upcomming release and close this issue.




Sergi Almacellas Abellana <pokoli>
Thu 06 Oct 2022 09:26:28 AM UTC, comment #2: 

Thanks, Sergi!

Sure, let's remove skiptest for the upcoming 4.2 series.

Please open a task for it.

Bests

Luis Falcon <meanmicio>
Group administrator
Thu 06 Oct 2022 07:57:52 AM UTC, comment #1: 

All files can be fixed with the following command:

find -iname '*.xml' -exec sed -i 's/skiptest="1" //' {} \;

Sergi Almacellas Abellana <pokoli>
Thu 06 Oct 2022 07:51:01 AM UTC, original submission:  

Since https://bugs.tryton.org/issue8735 (which landed on tryton 5.6) series, the skiptest attribute is no longer supported so it crashes when running tests:


======================================================================
ERROR: test_xml_files (trytond.modules.health.tests.test_health.HealthTestCase)
Test validity of the xml files of the module
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/pokoli/.virtualenvs/gnuhealth/lib/python3.10/site-packages/trytond/tests/test_tryton.py", line 204, in wrapper
    result = func(args, *kwargs)
  File "/home/pokoli/.virtualenvs/gnuhealth/lib/python3.10/site-packages/trytond/tests/test_tryton.py", line 800, in test_xml_files
    validator.assertValid(tree)
  File "src/lxml/etree.pyx", line 3640, in lxml.etree._Validator.assertValid
lxml.etree.DocumentInvalid: Invalid attribute skiptest for element data, line 3


As it will not produce any change on the production data, I think we can just remove it to avoid the error on the test suite. If you agree on this solution I will upload the fix for it.

P.S: There are other errors on the test suite but I prefer to work on them in separate issues.

Sergi Almacellas Abellana <pokoli>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meanmicio (Posted a comment)
  • -email is unavailable- added by pokoli (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-01-09 meanmicio ReleaseNone 4.1.0
    2022-10-06 pokoli StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Release4.1.0 None
    2022-10-06 meanmicio StatusNone In Progress
        ReleaseNone 4.1.0

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code