bugGNU Health - Bugs: bug #62626, banner from config not respected

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #62626: banner from config not respected

Submitter:  Gerald Wiese <gerald_wiese>
Submitted:  Tue 14 Jun 2022 02:27:00 PM UTC
 
Category:  GUI / Frontend Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  meanmicio
Open/Closed:  Closed Release:  4.0.0
Module:  gnuhealth client Component:  None

Wed 15 Jun 2022 11:07:27 AM UTC, comment #2: 
Luis Falcon <meanmicio>
Project Administrator
Wed 15 Jun 2022 11:04:18 AM UTC, comment #1: 

Thank you, Gerald!

Indeed, I forgot to pull the banner section from previous stable.

Will submit a patch now and release 4.0.1 of the hmis-client .

Bests
Luis

Luis Falcon <meanmicio>
Project Administrator
Tue 14 Jun 2022 02:27:00 PM UTC, original submission:  

The wikibooks documentation says that a custom banner can be used but the proposed config entry is not respected

https://en.wikibooks.org/wiki/GNU_Health/Installation#Using_a_custom_greeter_/_banner

In gnuhealth/gui/window/dblogin.py there is a line "image.set_from_file(os.path.join(PIXMAPS_DIR, BANNER))". If I change BANNER to CONFIG.config['client.banner'] it actually works the way it should.

Probably we should change it so that it tries to use the config and falls back to the static banner if no path is set / path does not exist / is not an image?

Gerald Wiese <gerald_wiese>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meanmicio (Posted a comment)
  • -email is unavailable- added by gerald_wiese (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-16 meanmicio StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2022-06-15 meanmicio StatusConfirmed Ready For Test
    2022-06-15 meanmicio CategoryNone GUI / Frontend
        StatusNone Confirmed
        Assigned toNone meanmicio
        ReleaseNone 4.0.0

    Back to the top


    Powered by Savane 3.9