bugGNU roff - Bugs: bug #62275, [build] rename GROFFBIN and...

 
 

bug #62275: [build] rename GROFFBIN and HDTBLGROFF macros

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Sat 09 Apr 2022 12:17:54 AM UTC
   
 
Category:  General Severity:  2 - Minor
Item Group:  Lint Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 11 Apr 2022 01:35:39 AM UTC, comment #2: 

comment #1:

>

[...]

> >
> >   The file GROFFBIN (=test-groff)
>
> No.
>


> Makefile.am:GROFFBIN = $(abs_top_builddir)/groff


>


Makefile.am:GROFFBIN = $(abs_top_builddir)/groff

 I changed that three and a half years ago in my private branch, so I
just have to adjust the arguments to my use of test-groff.

[...]

I don't know what you're trying to say here, but arguments to a groff command
neither "overwrite" nor "override" "internal assignments", by which I assume
you mean compiled-in defaults.  "-F" and "-M" options to groff (troff, nroff)
supplement those defaults.

 "overwrite" was the wrong word,
I meant "override" in the sense that -F
and -M arguments on the command line get checked (used) before the
environment variables.

[...]

Bjarni Ingi Gislason <bjarniig>
Sun 10 Apr 2022 01:32:29 AM UTC, comment #1: 


original submission:

> Subject: *.am files: repetition of contents of MFLAG and FFLAG for
> GROFFBIN
>
>   The file GROFFBIN (=test-groff)


No.


Makefile.am:GROFFBIN = $(abs_top_builddir)/groff



> already contains all tmac and font files used in the repository.


No, `GROFFBIN` does not.  `test-groff` is a shell script that configures environment variables such that tmac and font directories in both the source and build trees will be found, then calls the `groff` executable produced by the build.

>   This concerns "doc/doc.am" (DOC_GROFF) and "contrib/hdtbl/hdtbl.am"
> (HDTBLGROFF).



Automake files should define their own macros for calling the build tree's groff executable with appropriate flags, and in fact they already do this with DOC_GROFF and HDTBLGROFF (which should probably be renamed with an underscore for consistency).

One reason that this is a good idea is that it enables such Automake files to declare only the dependencies they require.  `test-groff` is for post-build evaluation (see INSTALL.extra) and "expects" everything to be built.  That makes it a poor choice for a within-build tool.
 

>   Arguments to a command overwrite internal assignments.


I don't know what you're trying to say here, but arguments to a groff command neither "overwrite" nor "override" "internal assignments", by which I assume you mean compiled-in defaults.  "-F" and "-M" options to groff (troff, nroff) supplement those defaults.

Please see the troff(1) man page.

I'm repurposing this ticket for some macro renames (it's somewhat seductive to rename "GROFFBIN" simply "GROFF", which doesn't appear to already be in use...but it might be too vague).

Otherwise I consider it invalid.

G. Branden Robinson <gbranden>
Group administrator
Sat 09 Apr 2022 12:17:54 AM UTC, original submission:  

Subject: *.am files: repetition of contents of MFLAG and FFLAG for
GROFFBIN

  The file GROFFBIN (=test-groff) already contains all tmac
and font files used in the repository.

  This concerns "doc/doc.am" (DOC_GROFF) and "contrib/hdtbl/hdtbl.am"
(HDTBLGROFF).

  Arguments to a command overwrite internal assignments.

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-04-10 gbranden Severity3 - Normal 2 - Minor
        Item GroupBuild/Installation Lint
        Summary*.am files: repetition of contents of MFLAG and FFLAG for GROFFBIN [build] rename GROFFBIN and HDTBLGROFF macros

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code