bugManeage - Bugs: bug #61846, Try to disable...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #61846: Try to disable nullability-completeness for flock.c for Darwin

Submitter:  Boud Roukema <boud>
Submitted:  Tue 18 Jan 2022 11:44:55 AM UTC
   
 
Category:  Software Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed

Tue 13 Sep 2022 11:05:45 AM UTC, comment #1: 

Since flock has been updated to 0.4.0 [1] and this appears to be stable, it seems to me that this bug can be safely closed. Since I was the person who posted it, I'm closing it. If there is a reason to re-open it, please say why and then re-open it.

[1] http://git.maneage.org/project.git/tree/reproduce/software/config/versions.conf#n29

Boud Roukema <boud>
Group Member
Tue 18 Jan 2022 11:44:55 AM UTC, original submission:  

Nullability completeness appears to be a requirement in recent
Darwin/xnu systems with an Xcode 12.5.1 [1] environment for
compiling C and C++ programs. One recent fix in Maneage was
implemented in commit a981196 [2], but this does not seem to
apply to flock, which is built by
`reproduce/software/shell/pre-make-build.sh`.

This commit 5690ab5 [0] adds `CFLAGS=-Wno-nullability-completeness' to
the `build_program' instruction in pre-make-build.sh with the
aim of compiling flock with this flag.

This commit [0] should hopefully solve the bug. In the source of
flock-0.2.3, `Makefile.am' includes `-Werror' as a C compile
flag, meaning that any warnings will be treated as errors.
The nullability attributes appear to only be used by clang,
not gcc. By disabling the `nullability-completeness' warning,
i.e. with `-Wno-nullability-completeness', the warning will
be omitted, so the Clang compiler should not consider there
to be a compilation error.

Since `flock' is the final tool built in pre-make-build.sh,
it seems that it is the only one that needs this compile
option for Darwin/xnu systems [3].

An alternative option for someone who knows what flock does
and has verified that the updates are safe could be to update
to flock-0.3.0 or flock-0.4.0 [4]. However, this tool is
used early in the whole build system, so the consequences of
an update would need to be well checked.


[0] https://codeberg.org/boud/maneage_dev/commit/5690ab5825d957d40d7a306d84e7a5bb98d6f522
[1] https://en.wikipedia.org/wiki/Xcode
[2] http://git.maneage.org/project.git/commit/?id=a981196b2e2eea6fe0517040c49a32f757ad28cf
[3] macOS adds GUIS on top of Darwin/xnu:
    https://en.wikipedia.org/wiki/MacOS#Architecture
[4] https://github.com/discoteq/flock/tags

Boud Roukema <boud>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by boud (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-09-13 boud StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code