bugphpGroupWare - Bugs: bug #6163, class.schema_proc.inc.php fais...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #6163: class.schema_proc.inc.php fais for default value

Submitted by:  Sigurd Nes <sigurdne>
Submitted on:  Sat 25 Oct 2003 05:08:13 PM UTC  
 
Item Group: 0.9.16.001Category: API - phpGroupware API
Severity: 4 - ImportantPriority: 5 - Normal
Status: FixedPrivacy: Public
Assigned to: Dave Hall <skwashd>Open/Closed: Closed
Component Version: SVNOperating System: None
Reproducibility: NonePlanned Release: None
Fixed Release: 

(Jump to the original submission Jump to the original submission)

Wed 14 Jul 2004 01:14:54 AM UTC, comment #9:

Andy,

thanks ... I assume this is tested. I had several versions of the fix, I obviously uploaded the wrong one.

Thanks again

fixed in cvs

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Tue 13 Jul 2004 02:52:16 PM UTC, comment #8:

On line 433:
elseif(!is_numeric($sDefault) && $sDefault != '')
^^^

will do.

Andreas Schiller <aschiller>
Sun 11 Jul 2004 10:22:36 AM UTC, comment #7:

I tested the attached fix, seems ok to me. Anyone want to check it?

btw is_numeric("+1 (000) 000-0000") === false

Format: RCS diff from cvs 11-Jul-2004@1015 UTC

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Wed 07 Jul 2004 09:19:05 PM UTC, comment #6:

From: Yoshihiro Kamimura <your@itheart.com>
I was tried to get cvs from .16-branch.
so, re-setup and re-create tables.

but, some error has...
(for Debug mode)
------------------------------------------------ here
Invalid SQL: CREATE TABLE phpgw_addressbook (id ...
MySQL Error: 1064 (Something is wrong in your syntax : '(000) 000-0000, tel_home varchar(40) NOT NULL DEFAULT +1 (000) 000-0000 ....
------------------------------------------------ here

DEFAULT statement (for tel-format string) is invalid to say.

ouch, intval("+1 (000) 000-0000") == true... gonna have to think about this one

Chris Weiss <cw>
Project Administrator
Tue 06 Jul 2004 08:26:30 PM UTC, comment #5:

hm, latest cvs .16 has the 2x' bug now too.

Zone: what database are you using? far as I can tell each class properly adds the ' itself.

I've fixed .16 and HEAD. Verified that each db class add the ' and the main class doesn't.

Chris Weiss <cw>
Project Administrator
Tue 06 Jul 2004 07:49:23 PM UTC, comment #4:

bug not present in .16, or if it is it's in one of the db specific files.

it's adding 2 ' in HEAD now.

Chris Weiss <cw>
Project Administrator
Sun 04 Jul 2004 02:58:02 AM UTC, comment #3:

The fix is wrong ... will fix it and retest

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Wed 30 Jun 2004 06:25:34 AM UTC, comment #2:

Fixed in 16 branch, will merge to head shortly

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Thu 15 Jan 2004 05:41:05 PM UTC, comment #1:

The attached patch fixes this. Tested with MySQL and Postgres. Raising the severity of this bug, as it makes HEAD uninstallable when using MySQL.

Jason W <Zone>
Sat 25 Oct 2003 05:08:13 PM UTC, original submission:

when inserting av default text-value 'A' - it tries to insert this as an integer.
line 389.
example:
DEFAULT A should read DEFAULT 'A'

Sigurd Nes <sigurdne>
Project Member

 

Attached Files
file #1541:  schema_proc.diff added by skwashd (364B - text/x-patch - the patch i should have attached)
file #987:  schema_proc_default_quotes.patch added by Zone (4KiB - application/octet-stream - Patch against HEAD on Thu Jan 15 17:35:25 UTC 2004)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 12 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 14 Jul 2004 01:14:54 AM UTCskwashdStatusWorks For Me=>Fixed
  Open/ClosedOpen=>Closed
Mon 12 Jul 2004 08:03:07 AM UTCskwashdAttached File-=>Added schema_proc.diff, #1482
Sun 11 Jul 2004 11:05:09 PM UTCskwashdItem GroupSVN trunk (dev code)=>0.9.16.001
Sun 11 Jul 2004 10:22:36 AM UTCskwashdStatusFixed=>Works For Me
  Open/ClosedClosed=>Open
Tue 06 Jul 2004 08:26:29 PM UTCcwOpen/ClosedOpen=>Closed
Sun 04 Jul 2004 02:58:02 AM UTCskwashdOpen/ClosedClosed=>Open
Wed 30 Jun 2004 06:25:34 AM UTCskwashdStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Thu 15 Jan 2004 05:41:05 PM UTCZoneSeverity3 - Normal=>4 - Important
  Attached File-=>Added schema_proc_default_quotes.patch, #967

Back to the top


Powered by Savane 3.1-cleanup1