bugGNU roff - Bugs: bug #61425, [man] aggressive breaking before...

 
 

bug #61425: [man] aggressive breaking before typeset URIs broke .UR within .TP

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Thu 04 Nov 2021 06:32:53 PM UTC
   
 
Category:  Macro man Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 06 Nov 2021 05:43:11 AM UTC, comment #1: 


commit 6aaef43904552889911e8a3e8d7006eb9f7adb64
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Nov 6 07:00:11 2021 +1100

    [man]: Fix paragraph tag regressions.

    * tmac/an-ext.mac (UR, MR): Only create an environment and diversion if
      we're not already in one of the latter.  If we are (in groff man, this
      occurs only when collecting a `TP` paragraph tag), then typeset the
      URI as part of the indented paragraph.

      (UE, ME): Pop the diversion and environment stacks only if we pushed
      them in the first place.  Eliminate spurious space in post-URI
      arguments by only typesetting excess macro parameters if there were
      any.

    Fixes <https://savannah.gnu.org/bugs/?61425>.

commit b5461ca30b0f91a3efdead93aa7d5c2dca112d27
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Nov 6 02:53:36 2021 +1100

    Revert "[man]: Modify typeset URI breaking strategy."

    This reverts commit c7efb5fd40aae5293d9de87092b7a4b2be89df91.

    Unfortunately this was not fully baked with respect to .UR/.UE or
    .MT/.ME embedding within a .TP paragraph tag.  Resolving that means
    coping with nested diversions.

    Better luck next time, I tell myself.

    tmac/tests/an-ext_link-macros-work-in-paragraph-tags.sh still fails.
    Will fix in next commit.

commit b11731541772c8fa46cf34d32db7dd60f6ed428a
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Nov 5 05:35:08 2021 +1100

    [man]: Regression-test Savannah #61425.

    * tmac/tests/an-ext_link-macros-work-in-paragraph-tags.sh: Do it.
    * tmac/tmac.am (tmac_TESTS): Run test.

    Also fix ordering of `tmac_TESTS`.

    Test fails at this commit.


G. Branden Robinson <gbranden>
Group administrator
Thu 04 Nov 2021 06:32:53 PM UTC, original submission:  

I regressed the ability to use .UR (or .MT) as a paragraph tag.

Also, my strategy for dealing with supernumerary arguments to .UE and .ME introduced unwanted whitespace.

Problem introduced by me in c7efb5fd, 1 November.

Fix pending.

G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-22 gbranden Item GroupNone Incorrect behaviour
    2021-11-06 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code