bugGNU troff - Bugs: bug #61324, tmac/pdfpic.tmac: make shell...

 
 

bug #61324: tmac/pdfpic.tmac: make shell pipeline called via .sy more robust

Submitter:  Dave <barx>
Submitted:  Sat 09 Oct 2021 11:24:45 PM UTC
 
Category:  Macro - others/general Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Duplicate
Privacy:  Public Assigned to:  barx
Open/Closed:  Closed Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Wed 26 Jan 2022 06:59:57 AM UTC, comment #4: 

Heinz-J├╝rgen Oertel replied to bug-groff: "I did testing it with some of my files, and, it works so far. Thanks for taking care"

Dave <barx>
Project Member
Sun 23 Jan 2022 02:17:02 AM UTC, comment #3: 

Heinz, bug #58206 has now been fixed.  If you're able, please test the fix by grabbing the latest tmac/pdfpic.tmac from git (this file has had some other cleanup done to it as well) to make sure it solves the problem you were seeing.  Thanks!

Dave <barx>
Project Member
Wed 03 Nov 2021 01:28:58 PM UTC, comment #2: 

Turns out bug #58206 was already open to address this.  Further discussion should be redirected there.

Dave <barx>
Project Member
Sat 23 Oct 2021 02:36:34 AM UTC, comment #1: 

Heinz, you've probably tested the various proposed solutions more than anyone -- do you have a preference between the awk command (posted at http://lists.gnu.org/archive/html/groff/2021-09/msg00061.html) and the sed one (posted at http://lists.gnu.org/archive/html/groff/2021-09/msg00062.html)?

Dave <barx>
Project Member
Sat 09 Oct 2021 11:24:45 PM UTC, original submission:  

As discussed on the email list (http://lists.gnu.org/archive/html/groff/2021-09/msg00046.html), tmac/pdfpic.tmac contains an external (.sy) call to a shell pipeline that includes a grep command which fails in cases where it falsely detects its input stream to be binary.  Further down the thread, a sed and an awk command are both proposed as more robust replacements for the grep.

Addressing bug #55107 will obviate the need for this shell pipeline at all.  This is the preferred fix for this problem.  But it's a more substantial change, and the fix proposed in the aforementioned email thread is simple and low-risk, so it's something that could be done until 55107 is addressed.

Dave <barx>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Updated the item)
  • -email is unavailable- added by barx (bug's original reporter)
  • -email is unavailable- added by barx (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-05 gbranden Assigned toNone barx
    2021-11-03 barx StatusNone Duplicate
        Open/ClosedOpen Closed
    2021-10-23 barx Carbon-Copy- Added -email is unavailable-

    Back to the top


    Powered by Savane 3.9