bugGNU roff - Bugs: bug #61213, test-suite.log is removed on build...

 
 

bug #61213: test-suite.log is removed on build failures

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Thu 23 Sep 2021 11:29:41 PM UTC
   
 
Category:  General Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 25 Sep 2021 02:37:32 PM UTC, comment #3: 


commit 2d07e05a541d1fe74819031abf422979a18ab48f
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Sep 24 17:04:36 2021 +1000

    Makefile.am: Don't delete test log on failures.

    * Makefile.am: Mark `$(TEST_SUITE_LOG)` as `.PRECIOUS`.  This prevents
      the test suite log from being deleted if there are any failures.

    Fixes <https://savannah.gnu.org/bugs/?61213>.  Thanks to Bjarni Ingi
    Gislason for the report, thus saving me from a certain TIA if I had come
    across it myself unexpectedly.


G. Branden Robinson <gbranden>
Group administrator
Fri 24 Sep 2021 07:02:29 AM UTC, comment #2: 

The solution is, fortunately, Make-idiomatic; use `.PRECIOUS`.

What's odd to me is why this is not the Automake default; the maintainer did not offer a rationale in 2013 when others stumbled across this issue.

See https://lists.gnu.org/archive/html/automake/2013-12/msg00025.html and follow-ups.

G. Branden Robinson <gbranden>
Group administrator
Fri 24 Sep 2021 03:25:28 AM UTC, comment #1: 


original submission:

> make[3]: * Deleting file 'test-suite.log'
> ============================================================================
> Testsuite summary for GNU Troff 1.22.4.3042-12706-dirty
> ============================================================================
> # TOTAL: 81
> # PASS:  77
> # SKIP:  0
> # XFAIL: 3
> # FAIL:  1
> # XPASS: 0
> # ERROR: 0
> ============================================================================
> See ./test-suite.log
> Please report to http://savannah.gnu.org/bugs/?group=groff


Hmm, yes, that is indeed unfortunate.

It appears that the upstream Automake test infrastructure doesn't play well with .DELETE_ON_ERROR.  Deleting the test log only if tests fail is guaranteed to cause frustration.

I'll need to either revert 71e31708 or figure out if Automake has some path to compatibility with this make(1) feature.

Thanks for catching this, Bjarni.

G. Branden Robinson <gbranden>
Group administrator
Thu 23 Sep 2021 11:29:41 PM UTC, original submission:  


  Output from "make check":

[...]
PASS: tmac/tests/s_TC-works-with-percent-in-custom-titles.sh
make[3]: * Deleting file 'test-suite.log'
============================================================================
Testsuite summary for GNU Troff 1.22.4.3042-12706-dirty
============================================================================
# TOTAL: 81
# PASS:  77
# SKIP:  0
# XFAIL: 3
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to http://savannah.gnu.org/bugs/?group=groff
[...]

  Probable cause is commit 71e31708e66872ff0a6c3e915713e891c8bc0b3a
dated Wed Sep 15 11:08:55 2021 +1000 with subject:

Makefile.am: Add `.DELETE_ON_ERROR` target.

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-03-05 gbranden CategoryNone General
    2021-09-25 gbranden CategoryCore None
        Item GroupIncorrect behaviour Build/Installation
        StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0
        Summary[Makefile] &quot;test-suite.log&quot; is removed test-suite.log is removed on build failures
    2021-09-24 gbranden StatusConfirmed In Progress
    2021-09-24 gbranden StatusNone Confirmed
        Assigned toNone gbranden

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code