bugGNU roff - Bugs: bug #61036, [gxditview] newer gnulib will...

 
 

bug #61036: [gxditview] newer gnulib will require additional linker options

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Thu 12 Aug 2021 11:56:58 PM UTC
   
 
Category:  Driver - others/general Severity:  1 - Wish
Item Group:  Build/Installation Status:  Invalid
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 26 Apr 2022 03:59:35 PM UTC, comment #7: 

Really setting status to "invalid".

G. Branden Robinson <gbranden>
Group administrator
Tue 26 Apr 2022 03:37:22 PM UTC, comment #6: 

Closing this ticket as invalid since no code changes were necessary.

G. Branden Robinson <gbranden>
Group administrator
Mon 25 Apr 2022 06:51:54 PM UTC, comment #5: 

  This in no longer needed.  Close ticket as invalid (or fixed?).

Bjarni Ingi Gislason <bjarniig>
Sat 21 Aug 2021 01:59:40 AM UTC, comment #4: 
G. Branden Robinson <gbranden>
Group administrator
Mon 16 Aug 2021 05:05:29 PM UTC, comment #3: 

I'm still baffled by this report.  I don't understand what is breaking or how your proposed patch fixes it.

libgroff does not provide its own implementation of fprintf.  It uses the system's.  It might use a libgnu (a.k.a. gnulib) replacement, but if so then the existing LDADD definition should suffice to bring it in.

Here's a list of printf-ish object file names in a recent build of mine.


$ find build -name "*printf*"
build/lib/printf-frexpl.o
build/lib/printf-frexp.o
build/lib/printf-parse.o
build/lib/vasnprintf.o
build/lib/printf-args.o
build/lib/.deps/vsnprintf.Po
build/lib/.deps/printf-frexpl.Po
build/lib/.deps/fprintf.Po
build/lib/.deps/asnprintf.Po
build/lib/.deps/snprintf.Po
build/lib/.deps/vasnprintf.Po
build/lib/.deps/printf-frexp.Po
build/lib/.deps/printf-parse.Po
build/lib/.deps/printf-args.Po
build/lib/asnprintf.o


Can you share the error output of a failed compilation?  And since you're using "additional options", can you also share a minimal set of such additional options that provoke the compilation failure in question?

G. Branden Robinson <gbranden>
Group administrator
Fri 13 Aug 2021 09:56:44 PM UTC, comment #2: 

  It was actually "libgroff_a-fprintf.o" that was missing before
"lib/libgnu".

  So the commit should have mentioned that.

A comment in the patch is also missing, for example:

/* Use 'libgroff.a' to get 'libgroff_a-fprintf.o' if needed. */

Bjarni Ingi Gislason <bjarniig>
Fri 13 Aug 2021 03:17:38 PM UTC, comment #1: 

I don't understand the patch.  How does forcing gxditview to link with libgroff haul in a working fprintf?

G. Branden Robinson <gbranden>
Group administrator
Thu 12 Aug 2021 11:56:58 PM UTC, original submission:  

From aecc6b9999b2036d8d42e57788a9766dcb798825 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Thu, 12 Aug 2021 13:36:19 +0000
Subject: [PATCH] xditview.am: add library to facilitate compilation with
 additional options

  The compiler options '-O...', '-D_FORTIFY_SOURCE=2' and
'-DGNULIB_NAMESPACE=gnulib' cause an error as "fprintf" is replaced by
"rpl_fprintf", and the needed subroutines are not found.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 src/devices/xditview/xditview.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/devices/xditview/xditview.am b/src/devices/xditview/xditview.am
index 00794d03..edd40c34 100644
--- a/src/devices/xditview/xditview.am
+++ b/src/devices/xditview/xditview.am
@@ -42,7 +42,7 @@ bin_PROGRAMS += gxditview
 gxditview_CPPFLAGS = $(AM_CPPFLAGS) $(X_CFLAGS) -Dlint \
   -I$(top_builddir)/src/devices/xditview
 gxditview_LDADD = $(X_LIBS) $(X_PRE_LIBS) -lXaw -lXmu -lXt -lX11 \
-  $(X_EXTRA_LIBS) $(LIBM) libxutil.a lib/libgnu.a
+  $(X_EXTRA_LIBS) $(LIBM) libxutil.a libgroff.a lib/libgnu.a
 XDITVIEW_GENHDRS = src/devices/xditview/GXditview-ad.h
 gxditview_SOURCES = $(GXDITVIEWSOURCES)
 nodist_gxditview_SOURCES = $(XDITVIEW_GENHDRS)
--
2.30.2


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-04-26 gbranden StatusFixed Invalid
    2022-04-26 gbranden StatusNone Fixed
        Assigned toNone gbranden
        Open/ClosedOpen Closed
    2021-08-21 gbranden Severity3 - Normal 1 - Wish
        StatusNeed Info None
        Summary[PATCH] xditview.am: add library to facilitate compilation with additional options [gxditview] newer gnulib will require additional linker options
    2021-08-13 gbranden StatusNone Need Info

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code