bugmake - Bugs: bug #60699, Avoid calling strlen repeatedly in...

 
 

bug #60699: Avoid calling strlen repeatedly in a loop.

Submitter:  Dmitry Goncharov <dgoncharov>
Submitted:  Sun 30 May 2021 12:08:15 AM UTC
   
 
Severity:  3 - Normal Item Group:  Enhancement
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.4 Operating System:  Any
Fixed Release:  4.4 Triage Status:  Small Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 06 Sep 2021 02:52:41 AM UTC, comment #3: 

Thanks, applied.

We should discuss how to manage patches on the mailing lists rather than here.  Using git branches in Savannah isn't so great for me because there's no code review feature.  It's actually simpler to have a discussion / patch review on the mailing lists than using git branches directly.

Paul D. Smith <psmith>
Group administrator
Sun 30 May 2021 03:45:49 PM UTC, comment #2: 

Sure, here is a unified diff.

Rather than attaching diffs, we could submit git branches for review. What do you think?

Dmitry Goncharov <dgoncharov>
Sun 30 May 2021 03:08:17 PM UTC, comment #1: 

Sorry I messed up; please use the '-u' option when creating diffs but don't use the '-b' option.  Can you re-attach as diffs without -u are not very helpful.

Sorry for the dumb mistake! :(

Paul D. Smith <psmith>
Group administrator
Sun 30 May 2021 12:08:15 AM UTC, original submission:  

Avoid calling strlen repeatedly in a loop in initialize_file_variables.

Dmitry Goncharov <dgoncharov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51499:  sv60699_fix.diff added by dgoncharov (1KiB - text/x-patch)
file #51497:  sv60699_fix.diff added by dgoncharov (570B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by dgoncharov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-09-06 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Operating SystemNone Any
        Fixed ReleaseNone 4.4
        Triage StatusNone Small Effort
    2021-05-30 dgoncharov Attached File- Added sv60699_fix.diff, #51499
    2021-05-30 dgoncharov Attached File- Added sv60699_fix.diff, #51497

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code