bugGNU Octave - Bugs: bug #60606, [octave forge] (signal) cplxreal...

 
 

bug #60606: [octave forge] (signal) cplxreal error on odd number of zeros

Submitted by:  Charles Praplan <charprap>
Submitted on:  Fri 14 May 2021 12:32:01 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 17 May 2021 02:17:42 PM UTC, comment #2: 

Here is the patch file with test cases.

(file #51448)

Charles Praplan <charprap>
Sun 16 May 2021 05:30:16 AM UTC, comment #1: 

Thanks, it would help if you could submit this change in the form of a patch file instead of an entire copy of the function.

I would delete the original line entirely instead of making a copy of it as a comment. I would also write the improved condition as

while ((idx > 0) && (zcp(idx) == 0 || (abs (imag (zcp(idx))) ./ abs (zcp(idx))) <= tol))

Are you planning to post another revision with a test for this case?

Mike Miller <mtmiller>
Project Administrator
Fri 14 May 2021 12:32:01 PM UTC, original submission:  

The function cplxreal handles real zero at zero as complex.
A correction is appended.
The final version will include an additional test case.

Charles Praplan <charprap>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51448:  cplxreal.patch added by charprap (1KiB - application/octet-stream)
file #51433:  cplxreal.m added by charprap (3KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by charprap (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-05-17 charprap Attached File- => Added cplxreal.patch, #51448
    2021-05-16 mtmiller Item GroupIncorrect Result => Unexpected Error or Warning
        Release6.2.0 => dev
        Summary[octave forge] (signal) cplxreal fct handles real zero at zero as complex => [octave forge] (signal) cplxreal error on odd number of zeros
    2021-05-14 siko1056 CategoryNone => Octave Forge Package
        Summarycplxreal fct handles real zero at zero as complex => [octave forge] (signal) cplxreal fct handles real zero at zero as complex
    2021-05-14 charprap Attached File- => Added cplxreal.m, #51433

    Back to the top


    Powered by Savane 3.6