bugGNU Octave - Bugs: bug #59553, default doesn't build on macOS

 
 

bug #59553: default doesn't build on macOS

Submitter:  Ben Abbott <bpabbott>
Submitted:  Thu 26 Nov 2020 07:46:12 PM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 6.1.0 Operating System:  * Mac OS
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 28 Nov 2020 02:46:13 PM UTC, comment #3: 

Thank you for testing.
IIUC, the same might happen on stable. So, I pushed a change here:
https://hg.savannah.gnu.org/hgweb/octave/rev/d34558c873dc

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Sat 28 Nov 2020 04:16:22 AM UTC, comment #2: 

@Marcus,

Thanks, that works.


Octave successfully built.  Now choose from the following:

   ./run-octave    - to run in place to test before installing
   make check      - to run the tests
   make install    - to install (PREFIX=/usr/local/bpabbott/octave)

   HG ID for this build is "944fd6fca864+"

Bens-MacBook-Pro:sources bpabbott$ hg diff
diff --git a/libgui/src/documentation.cc b/libgui/src/documentation.cc
--- a/libgui/src/documentation.cc
+++ b/libgui/src/documentation.cc
@@ -36,7 +36,7 @@
 #include <QFileInfo>
 #include <QHelpContentWidget>
 #include <QHelpIndexWidget>
-#if defined (HAVE_NEW_QHELPINDEXWIDGET_API)
+#if defined (HAVE_NEW_QHELPINDEXWIDGET_API) || defined (HAVE_QHELPENGINE_DOCUMENTSFORIDENTIFIER)
 #  include <QHelpLink>
 #endif
 #include <QHelpSearchEngine>


Ben Abbott <bpabbott>
Group Member
Fri 27 Nov 2020 10:18:51 AM UTC, comment #1: 

Does this change help?

diff -r 44c253973f0f libgui/src/documentation.cc
--- a/libgui/src/documentation.cc        Fri Nov 27 08:47:36 2020 +0100
+++ b/libgui/src/documentation.cc        Fri Nov 27 11:16:43 2020 +0100
@@ -36,7 +36,7 @@
 #include <QFileInfo>
 #include <QHelpContentWidget>
 #include <QHelpIndexWidget>
-#if defined (HAVE_NEW_QHELPINDEXWIDGET_API)
+#if defined (HAVE_NEW_QHELPINDEXWIDGET_API) || defined (HAVE_QHELPENGINE_DOCUMENTSFORIDENTIFIER)
 #  include <QHelpLink>
 #endif
 #include <QHelpSearchEngine>


Markus Mützel <mmuetzel>
Group administrator
Thu 26 Nov 2020 07:46:12 PM UTC, original submission:  

Changeset 0678fdb81efc broke building on macOS to me. I've attached the end of the make. The changeset didn't revert cleanly. Thus, I've also attached a patch for reverting the changeset.

Ben Abbott <bpabbott>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #50347:  make_log.txt added by bpabbott (17KiB - text/plain - end of make and patch needed to build)
file #50348:  rev_0678fdb81efc.diff added by bpabbott (4KiB - application/octet-stream - end of make and patch needed to build)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by bpabbott (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-11-28 mmuetzel StatusNeed Info Fixed
        Open/ClosedOpen Closed
        Releasedev 6.1.0
    2020-11-27 mmuetzel StatusNone Need Info
    2020-11-26 bpabbott Attached File- Added make_log.txt, #50347
        Attached File- Added rev_0678fdb81efc.diff, #50348

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code