bugGNU roff - Bugs: bug #59186, tarball builds break to due to...

 
 

bug #59186: tarball builds break to due to mdoc relocation

Submitter:  None
Submitted:  Sat 26 Sep 2020 04:21:53 PM UTC
   
 
Category:  General Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 27 Sep 2020 02:13:40 AM UTC, comment #5: 

You'll also want the commit after that to solve unrelated distribution archive generation.


commit f2f261e8db3f5c24ea5b520480b82556f380121b (HEAD -> master, origin/master, origin/HEAD)
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Sep 27 12:03:20 2020 +1000

    Ship tests in distribution archive.

    * src/preproc/preconv/preconv.am (EXTRA_DIST):
    * src/roff/groff/groff.am (EXTRA_DIST):
    * src/roff/nroff/nroff.am (EXTRA_DIST):
    * tmac/tmac.am (EXTRA_DIST): Add $({preconv,groff,nroff,tmac}_TESTS), as
      appropriate.

    * src/roff/nroff/nroff.am (MOSTLYCLEANFILES): Stop adding
      $(nroff_TESTS), which can only have unhappy consequences.


G. Branden Robinson <gbranden>
Group administrator
Sun 27 Sep 2020 02:11:57 AM UTC, comment #4: 

Fixed in git.  Thank you again for the report.


commit 00bccfc7418ef7d55ddbf527af0f50c64bb76fa7
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Sep 27 11:52:09 2020 +1000

    tmac/tmac.am: Fix Savannah #59186.

    * tmac/tmac.am: Fix problem with recently-relocated mdoc macro files not
      ending up in the right place in the distribution archive.

      (dist_tmac_DATA): Also include $(TMACUNSTRIPFILES).

      (TMACMDOCSTRIPFILES): Rename from $(TMACMDOCFILES).  Update
      interpolation sites.

      (TMACMDOCUNSTRIPFILES): New variable holds mdoc macro files in the
      tmac/mdoc subdirectory.  Stop adding these files to
      $(TMACUNSTRIPFILES) since those reside in tmac/ directly.

      (EXTRA_DIST): Add $(TMACMDOCUNSTRIPFILES).

      ($(TMACSTRIPFILES)): Depend only on $(TMACUNSTRIPFILES).

      ($(TMACMDOCSTRIPFILES)): Add new rule, much like the foregoing.
      Depend on $(TMACMDOCUNSTRIPFILES) and copy files into tmac/mdoc.

      (dist-hook, tmac-dist-hook): Remove; they no longer do any distinct
      work.


G. Branden Robinson <gbranden>
Group administrator
Sun 27 Sep 2020 01:07:22 AM UTC, comment #3: 

There were other problems arising from `tests` directories not being added to EXTRA_DIST, but I've resolved them now.


=============================================================
groff-1.22.4.474-f431-dirty archives ready for distribution:
groff-1.22.4.474-f431-dirty.tar.gz
=============================================================



G. Branden Robinson <gbranden>
Group administrator
Sat 26 Sep 2020 10:44:38 PM UTC, comment #2: 

The true culprit appears to be the commit that relocated mdoc within the build tree.


commit de1e4091311d74ab2af19aa0d376c5d228a14280
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Aug 25 17:52:55 2020 +1000

    mdoc: Relocate within build tree.

    The (modern) mdoc macro package has not been usable within the build
    tree, unlike the others.  This makes it more troublesome to test
    changes, and frustrates deploying our test infrastructure against it.
    Re-arrange the build tree to resemble an installation tree closely
    enough for the macro package to load.

            renamed:    doc-common-u -> mdoc/doc-common-u
            renamed:    doc-ditroff-u -> mdoc/doc-ditroff-u
            renamed:    doc-nroff-u -> mdoc/doc-nroff-u
            renamed:    doc-syms-u -> mdoc/doc-syms-u

    * tmac/tmac.am (TMACMDOCFILES): Look for files in tmac/mdoc.
      ($(TMACMDOCFILES)): Create tmac/mdoc in build tree.

    Fixes <https://savannah.gnu.org/bugs/index.php?51003>.


G. Branden Robinson <gbranden>
Group administrator
Sat 26 Sep 2020 10:41:07 PM UTC, comment #1: 

Unfortunately the attached log omitted the most useful line:


make[1]: *** No rule to make target 'tmac/mdoc/doc-common-u', needed by 'tmac/e.tmac'.  Stop.


Also, the reproducer script, while useful, failed to also clone the gnulib repository, which is necessary for a build in an otherwise clean directory tree.

I'm attaching my modified version.

Thanks for the report!

(file #49864)

G. Branden Robinson <gbranden>
Group administrator
Sat 26 Sep 2020 04:21:53 PM UTC, original submission:  

https://git.savannah.gnu.org/cgit/groff.git/commit/?id=2c9484fc9957cfe531fdbbe9d6b1fc3561baede5

Description:

Compilation error

Steps to Reproduce:

Precondition: gnulib was downloaded from git repo HEAD

git clone git://git.savannah.gnu.org/groff.git
cd groff/
./bootstrap --copy --gnulib-srcdir=../gnulib
./configure
make -j1
make dist-xz
mv groff*.tar.xz ..
cd ../
rm -rf groff
tar xf groff*.tar.xz
rm -r groff*.tar.xz
mv groff* groff
rm -rf groff/.git
tar czf groff.tar.gz groff
rm -rf groff
tar xf groff.tar.gz
cd groff/
PAGE=letter ./configure --prefix=/usr
make -j1

Expected Results:

compilation pass

Actual Results:

Compilation error... see log


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49864:  masmullin-modified.sh added by gbranden (521B - application/x-shellscript)
file #49862:  comp.log added by None (13KiB - text/x-log)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-15 gbranden CategoryNone General
    2020-09-27 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0
    2020-09-27 gbranden StatusConfirmed In Progress
    2020-09-26 gbranden SummaryCompilation Break due to commit: 2c9484fc9957cfe531fdbbe9d6b1fc3561baede5 tarball builds break to due to mdoc relocation
    2020-09-26 gbranden Attached File- Added masmullin-modified.sh, #49864
        StatusNone Confirmed
        Assigned toNone gbranden
    2020-09-26 None Attached File- Added comp.log, #49862

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code