bugGNU Octave - Bugs: bug #59114, RapidJSON feature test is...

 
 

bug #59114: RapidJSON feature test is unspecific

Submitter:  Markus Mützel <mmuetzel>
Submitted:  Tue 15 Sep 2020 05:58:02 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 17 Sep 2020 06:26:45 PM UTC, comment #3: 

Thanks. Works for me as expected.

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Thu 17 Sep 2020 02:45:46 PM UTC, comment #2: 

I checked in a changeset which makes the configure test much more specific here: http://hg.savannah.gnu.org/hgweb/octave/rev/699bba597610.

It use AC_COMPILE_IFELSE and I use a fragment of code that must compile for the feature to work with Octave.  I also renamed the feature from HAVE_RAPIDJSON_DEV which specified a version to HAVE_RAPIDJSON_PRETTYWRITER which describes the feature in the library that we are testing for.

Marking as Ready for Test.

Rik <rik5>
Group administrator
Wed 16 Sep 2020 03:34:32 PM UTC, comment #1: 

I agree, test for the features we need and never just for version numbers.

Rik <rik5>
Group administrator
Tue 15 Sep 2020 05:58:02 PM UTC, original submission:  

On 8/18/20, jwe wrote on the mailing list:

> Thanks for working on this new feature.
>
> After
>
>   changeset:   28623:5da49e37a6c9
>   user:        Abdallah Elshamy <abdallah.k.elshamy@gmail.com>
>   date:        Thu Aug 13 23:57:07 2020 +0900
>   summary:     New functions jsondecode and jsonencode (bug #53100).
>
> I noticed all tests for jsonencode and jsondecode were skipped on my
> system.  I have
>
>   ii  rapidjson-dev  1.1.0+dfsg2-6 all          fast JSON
> parser/generator for C++ with SAX/DOM style API
>
> installed.  When running configure, I see
>
>   configure: WARNING: RapidJSON 1.1.0 or older found, but latest
> development version needed.  Octave will not be able to read or write
> JSON files.
>
> The configure test that generates that message checks for
> rapidjson/cursorstreamwrapper.h, but the error message is about the
> RapidJSON version, and cursorstreamwrapper.h does not appear to be used
> directly in the Octave sources.  What feature(s) do we really need here?
>  If possible, think we should check for the required features and, if
> they are not found, issue a warning about that rather than something
> about a version since the need for a development version will likely
> change soon.


I agree that it would probably be better to test for the feature we use (i.e., rapidjson::PrettyWriter IIUC).

Opening a bug report so that this doesn't get lost.

Markus Mützel <mmuetzel>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-09-17 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2020-09-17 rik5 Item GroupNone Other
        StatusConfirmed Ready For Test
    2020-09-16 rik5 StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code